Update config-cheat-sheet.en-us.md #8497
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add more information on configuring URI hyperlink rendering for Markdown.
7 tasks
guillep2k
reviewed
Oct 14, 2019
| @@ -108,6 +108,8 @@ Values containing `#` or `;` must be quoted using `` ` `` or `"""`. | |||
| ## Markdown (`markdown`) | |||
|
|
|||
| - `ENABLE_HARD_LINE_BREAK`: **false**: Enable Markdown's hard line break extension. | |||
| - `CUSTOM_URL_SCHEMES`: : Use a comma separated list (http,https,ftp,git,svn) to indicate | |||
| URI hyperlinks that should be rendered in Markdown. The default is only http and https. | |||
There was a problem hiding this comment.
It's not URI but URL in this case. Also, http and https are always rendered no matter what this setting says.
There was a problem hiding this comment.
I think this should be part of the pr that does the custom URL schemes assuming we haven't merged that yet
There was a problem hiding this comment.
@guillep2k @zeripath Thanks for suggestions. Updated contents as suggested. Feel free to incorporate into pr for custom URL schemes.
GiteaBot
added
the
lgtm/need 2
Update description as suggested by @guillep2k
Codecov Report
@@ Coverage Diff @@
## master #8497 +/- ##
==========================================
- Coverage 41.72% 41.71% -0.02%
==========================================
Files 512 512
Lines 66942 66942
==========================================
- Hits 27930 27923 -7
- Misses 35422 35433 +11
+ Partials 3590 3586 -4
Continue to review full report at Codecov.
|
sapk
approved these changes
Oct 14, 2019
GiteaBot
added
lgtm/need 1
guillep2k
reviewed
Oct 14, 2019
Co-Authored-By: guillep2k <[email protected]>
guillep2k
approved these changes
Oct 14, 2019
GiteaBot
added
lgtm/done
|
Build failing due to #8474 unrelated to this PR. |
|
Make lg-tm work |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add more information on configuring URI hyperlink rendering for Markdown.
Partially addressing #8478