Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix vendor #7394

Merged
merged 1 commit into from
Jul 9, 2019
Merged

Fix vendor #7394

merged 1 commit into from
Jul 9, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented Jul 9, 2019 •
edited
Loading

The previous date is wrong in fact.
How did I get the correct datetime on version.

STEP 1:

+replace github.com/denisenkom/go-mssqldb => github.com/denisenkom/go-mssqldb v0.0.0-20180314172330-6a30f4e59a44
-replace github.com/denisenkom/go-mssqldb => github.com/denisenkom/go-mssqldb 6a30f4e59a44

STEP 2:

make vendor

@lunny lunny requested a review from sapk July 9, 2019 05:29
@lunny lunny mentioned this pull request Jul 9, 2019
Closed
@lunny lunny added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile backport/v1.9 labels Jul 9, 2019
@lunny lunny added this to the 1.10.0 milestone Jul 9, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@46d3d10). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #7394   +/-   ##
========================================
  Coverage          ?   41.2%           
========================================
  Files             ?     469           
  Lines             ?   63536           
  Branches          ?       0           
========================================
  Hits              ?   26178           
  Misses            ?   33937           
  Partials          ?    3421

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 46d3d10...cb0f081. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 9, 2019
@lunny lunny mentioned this pull request Jul 9, 2019
Merged
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 9, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 9, 2019
@lunny lunny merged commit f03e5b7 into go-gitea:master Jul 9, 2019
@lunny lunny deleted the lunny/fix_vendor branch July 9, 2019 06:27
lunny added a commit to lunny/gitea that referenced this pull request Jul 9, 2019
@lunny
fix vendor (go-gitea#7394)
be2c80d
@lunny lunny mentioned this pull request Jul 9, 2019
Merged
@lunny lunny added the backport/done All backports for this PR have been created label Jul 9, 2019
techknowlogick pushed a commit that referenced this pull request Jul 9, 2019
@lunny @techknowlogick
Fix vendor (#7394) (#7396)
a360dae
@sapk
Copy link
Member

sapk commented Jul 9, 2019 •
edited
Loading

That my bad when I was bisecting to find the blocking commit, I discover that the date is purely informative in the go.mod (at least to get the corresponding files) so I just change the commit id but I fotgot to update the date for the final fix. Sorry.

jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@lunny @jeffliu27
fix vendor (go-gitea#7394)
dee433c
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

@sapk sapk Awaiting requested review from sapk

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.10.0
Development

Successfully merging this pull request may close these issues.
6 participants
@lunny @codecov-io @sapk @techknowlogick @lafriks @GiteaBot