Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full directory support for wiki #7390

Closed
wants to merge 4 commits into from
Closed

Conversation

Cherrg
Copy link
Contributor

@Cherrg Cherrg commented Jul 8, 2019

directory support for wiki

previously this was part of #7225 - lets split it up

This PR

  • add support for directories inside wiki. Create/update/delete pages works well. If an old page is updated, the file will be moved to subdirectory.
    • allows to read files with nearly all letters, as it is possible to push all via wiki gitrepo
      • files can exists in old and new structure.
        • files are selected by link, so it is possible to access and view both
        • writing to one of them will delete both, and create new one in directory structure
        • delete will delete the selected file
    • support images relative to directory path
      • fix preview on preview rendering
    • fix 500 error if wiki contains pages with invalid uri encoding (e.g. filename: badescaping%%.md)
  • ui fixes
    • add button 'Abort' to wiki edit and new page

fix #823

Signed-off-by: Michael Gnehr [email protected]

+ add _delete to reserved keywords

Signed-off-by: Michael Gnehr <[email protected]>
see go-gitea#7225 for more details

Signed-off-by: Michael Gnehr <[email protected]>
Signed-off-by: Michael Gnehr <[email protected]>
@codecov-io
Copy link

Codecov Report

Merging #7390 into master will increase coverage by 0.03%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7390      +/-   ##
==========================================
+ Coverage   41.19%   41.22%   +0.03%     
==========================================
  Files         469      469              
  Lines       63536    63635      +99     
==========================================
+ Hits        26171    26235      +64     
- Misses      33943    33970      +27     
- Partials     3422     3430       +8
Impacted Files Coverage Δ
modules/markup/markdown/markdown.go 80.95% <ø> (+2.24%) ⬆️
routers/routes/routes.go 82.38% <100%> (+0.02%) ⬆️
routers/repo/wiki.go 40.95% <55.35%> (+0.07%) ⬆️
models/wiki.go 59.72% <72.63%> (+2.84%) ⬆️
models/unit.go 62.16% <0%> (-5.41%) ⬇️
models/repo_list.go 73.09% <0%> (+1.01%) ⬆️
modules/log/event.go 65.64% <0%> (+1.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c3f749...d10e0fd. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 9, 2019
@lunny
Copy link
Member

lunny commented Sep 6, 2019

Please resolve the conflicts

@lunny lunny added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Sep 6, 2019
@@ -136,6 +198,9 @@ func (repo *Repository) updateWikiPage(doer *User, oldWikiName, newWikiName, con
}

gitRepo, err := git.OpenRepository(basePath)

fmt.Println(reflect.TypeOf(gitRepo))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not needed

@stale
Copy link

stale bot commented Nov 5, 2019

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

@stale stale bot added the issue/stale label Nov 5, 2019
@lunny lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label Nov 5, 2019
@stale stale bot removed the issue/stale label Nov 5, 2019
@lunny lunny added this to the 1.11.0 milestone Nov 16, 2019
@lunny
Copy link
Member

lunny commented Dec 13, 2019

Please resolve the conflicts.

@gsantner
Copy link

@Cherrg

@lunny lunny modified the milestones: 1.11.0, 1.12.0 Dec 17, 2019
@ferrydeboer
Copy link

ferrydeboer commented Mar 26, 2020

Well, this is a bit frustrating seeing this stale PR. Would really appreciate this feature. :( To bad I'm not proficient at Go.

@lunny lunny modified the milestones: 1.12.0, 1.x.x May 2, 2020
@lunny lunny removed this from the 1.x.x milestone Jan 18, 2023
@wxiaoguang
Copy link
Contributor

This PR has been stale for long time, and the Wiki Title problem has been improved by #24143

Would there be new progress of this PR?

@wxiaoguang wxiaoguang added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Apr 25, 2023
@wxiaoguang
Copy link
Contributor

It has been stale for a long time and I can't think of a way to handling it other than closing it. Feel free to reopen if there's any new progress and I could also help.

@wxiaoguang wxiaoguang closed this May 1, 2023
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Hierarchy (sub directory) in Wiki
8 participants