Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update drone to use drone 1 format #7331

Closed
wants to merge 17 commits into from

Conversation

kolaente
Copy link
Member

@kolaente kolaente commented Jun 30, 2019

Successor of #6602, fixes #6463

I've refactored the drone file to use the new syntax of drone 1, which brings several advanteges:

  • multiple pipelines
  • dependencies of steps -> paralle execution of tests

Multiple pipelines:

  • testing: Runs all linters, unit and integration tests
  • translations: Downloads the newest translations from crowdin and also pushes them back to the repo
  • release: cross-compiles releases with xgo and publishes them
  • docs: publishes the docs
  • docker: builds and publishes the docker images
  • notify: triggers the discord notify hook

@kolaente
Copy link
Member Author

kolaente commented Jun 30, 2019

From the parallelization the whole pipeline now takes ~15min instead of 35min for a pr! 🎉

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 30, 2019
@kolaente
Copy link
Member Author

Hmm weired, when I run drone lint locally, it does not complain, only on drone.gitea.io....

@kolaente
Copy link
Member Author

kolaente commented Jun 30, 2019

The translations, release, docker and docs pipelines run even though I specified an exclude condition for prs:

when:
  event:
    exclude:
      - pull_request

I've also tried

when:
  branch:
    - master
  event:
    exclude:
      - pull_request

which didn't work either.

EDIT: I've also tried

when:
  branch:
    - master
  event:
    - push

which didn't work.

@techknowlogick @tboerger @zeripath @lunny @appleboy any ideas?

@kolaente kolaente changed the title Update drone to use drone 1 format WIP: Update drone to use drone 1 format Jun 30, 2019
@kolaente
Copy link
Member Author

kolaente commented Jun 30, 2019

I've changed the pipeline conditions to use trigger instead and it works now.

Signed-off-by: konrad <[email protected]>
@kolaente kolaente changed the title WIP: Update drone to use drone 1 format Update drone to use drone 1 format Jun 30, 2019
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@17fa227). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7331   +/-   ##
=========================================
  Coverage          ?   41.24%           
=========================================
  Files             ?      466           
  Lines             ?    63153           
  Branches          ?        0           
=========================================
  Hits              ?    26045           
  Misses            ?    33702           
  Partials          ?     3406

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 17fa227...d7839be. Read the comment docs.

kolaente added a commit to appleboy/gitea that referenced this pull request Jun 30, 2019
@kolaente
Copy link
Member Author

Closing this in favour of #6602.

@kolaente kolaente closed this Jun 30, 2019
techknowlogick pushed a commit that referenced this pull request Jun 30, 2019
* chore: update drone format to 1.0

* Converted old drone config

Signed-off-by: konrad <[email protected]>

* Moved translations to seperate pipeline

Signed-off-by: konrad <[email protected]>

* Split the steps in multiple pipelines and add dependencies

Signed-off-by: konrad <[email protected]>

* format

Signed-off-by: konrad <[email protected]>

* Fixed step depenednecies

Signed-off-by: konrad <[email protected]>

* Fixed discord notify

Signed-off-by: konrad <[email protected]>

* Exclude translations and docs pipelines from prs

Signed-off-by: konrad <[email protected]>

* Fixed exclude prs

Signed-off-by: konrad <[email protected]>

* Fixed exclude prs

Signed-off-by: konrad <[email protected]>

* Moved releases to seperate pipeline

Signed-off-by: konrad <[email protected]>

* Re-trigger drone

Signed-off-by: konrad <[email protected]>

* Disable release step

Signed-off-by: konrad <[email protected]>

* Fixed depending step

Signed-off-by: konrad <[email protected]>

* Adopted dependencies

Signed-off-by: konrad <[email protected]>

* Changed pipeline conditions

Signed-off-by: konrad <[email protected]>

* Replaced pipeline conditions with triggers

Signed-off-by: konrad <[email protected]>

* Fixed coverage step

Signed-off-by: konrad <[email protected]>

* Import changes from #7331

Signed-off-by: konrad <[email protected]>

* Add comment for lowest go version

Signed-off-by: konrad <[email protected]>

* Exclude fetch-tags from prs

Signed-off-by: konrad <[email protected]>

* Re-added comment about no tags

Signed-off-by: konrad <[email protected]>

* Removed unneeded conditions

Signed-off-by: konrad <[email protected]>

* Moved release version and release latest to different pipelines

Signed-off-by: konrad <[email protected]>

* Fixed depending pipeline

Signed-off-by: konrad <[email protected]>

* Removed the conditions for all services

Signed-off-by: konrad <[email protected]>
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
* chore: update drone format to 1.0

* Converted old drone config

Signed-off-by: konrad <[email protected]>

* Moved translations to seperate pipeline

Signed-off-by: konrad <[email protected]>

* Split the steps in multiple pipelines and add dependencies

Signed-off-by: konrad <[email protected]>

* format

Signed-off-by: konrad <[email protected]>

* Fixed step depenednecies

Signed-off-by: konrad <[email protected]>

* Fixed discord notify

Signed-off-by: konrad <[email protected]>

* Exclude translations and docs pipelines from prs

Signed-off-by: konrad <[email protected]>

* Fixed exclude prs

Signed-off-by: konrad <[email protected]>

* Fixed exclude prs

Signed-off-by: konrad <[email protected]>

* Moved releases to seperate pipeline

Signed-off-by: konrad <[email protected]>

* Re-trigger drone

Signed-off-by: konrad <[email protected]>

* Disable release step

Signed-off-by: konrad <[email protected]>

* Fixed depending step

Signed-off-by: konrad <[email protected]>

* Adopted dependencies

Signed-off-by: konrad <[email protected]>

* Changed pipeline conditions

Signed-off-by: konrad <[email protected]>

* Replaced pipeline conditions with triggers

Signed-off-by: konrad <[email protected]>

* Fixed coverage step

Signed-off-by: konrad <[email protected]>

* Import changes from go-gitea#7331

Signed-off-by: konrad <[email protected]>

* Add comment for lowest go version

Signed-off-by: konrad <[email protected]>

* Exclude fetch-tags from prs

Signed-off-by: konrad <[email protected]>

* Re-added comment about no tags

Signed-off-by: konrad <[email protected]>

* Removed unneeded conditions

Signed-off-by: konrad <[email protected]>

* Moved release version and release latest to different pipelines

Signed-off-by: konrad <[email protected]>

* Fixed depending pipeline

Signed-off-by: konrad <[email protected]>

* Removed the conditions for all services

Signed-off-by: konrad <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drone 1.0.0 yaml
3 participants