-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix topic bar to allow prefixes #7325
Conversation
- allow prefixes by adding current request content to result list - remove html-tags before insert on page fix go-gitea#7126 Signed-off-by: Michael Gnehr <[email protected]>
This looks better thank you! Would it be possible instead of (or in addition to) adding the current request to the list to also not show something that is already a tag (or been entered but not yet saved in the current session). So as an example here: It shouldn't show golang as a suggestion since it has already been selected and will just disappear if you try to pick it a second time. |
Signed-off-by: Michael Gnehr <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #7325 +/- ##
==========================================
- Coverage 41.24% 41.23% -0.01%
==========================================
Files 466 466
Lines 63153 63153
==========================================
- Hits 26045 26043 -2
- Misses 33702 33705 +3
+ Partials 3406 3405 -1
Continue to review full report at Codecov.
|
i didn't notice that there where other class names for previously present topics and new added ones. |
Signed-off-by: Michael Gnehr <[email protected]>
That looks great thank you for all of these PRs they really add up! |
Please don't land yet until above comment is resolved (seems I lack permission to block this PR via negative review). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per @silverwind
Don't worry I'm fairly certain our merging stuff wouldn't let us merge in any case. |
thanks to @silverwind Signed-off-by: Michael Gnehr <[email protected]>
Should be good to go. |
* - do not select if escape is pressed - allow prefixes by adding current request content to result list - remove html-tags before insert on page fix go-gitea#7126 Signed-off-by: Michael Gnehr <[email protected]> * sort current query to top Signed-off-by: Michael Gnehr <[email protected]> * remove already added topics from dropdown list Signed-off-by: Michael Gnehr <[email protected]> * protoct against xss thanks to @silverwind Signed-off-by: Michael Gnehr <[email protected]>
Update
fix #7126 (Unable to create a new topic because it's a substring of an existing one)
Signed-off-by: Michael Gnehr [email protected]