-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Submodule dection in subdir #7275
Conversation
Include the directory in name when looking for matching Submodule from .gitmodules file Fixes go-gitea#7262
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I sincerely wish we'd insisted on always returning the full name from the git entry functions. Bugs like this would not be able to sneak in.
Codecov Report
@@ Coverage Diff @@
## master #7275 +/- ##
==========================================
- Coverage 40.99% 40.98% -0.01%
==========================================
Files 462 462
Lines 62578 62584 +6
==========================================
- Hits 25654 25652 -2
- Misses 33562 33570 +8
Partials 3362 3362
Continue to review full report at Codecov.
|
Please send back port to v1.8 |
@lunny this file was previously part of go-gitea/git which has now been archived. If you want to unarchive I could send a PR, but maybe not necessary if we are going to try and release 1.9 soon |
OK. |
Include the directory in name when looking for matching Submodule from .gitmodules file Fixes go-gitea#7262
Include the directory in name when looking for matching Submodule from .gitmodules file
Fixes #7262