Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark theme markdown fixes #7260

Merged
merged 5 commits into from
Jun 21, 2019
Merged

Dark theme markdown fixes #7260

merged 5 commits into from
Jun 21, 2019

Conversation

Cherrg
Copy link
Contributor

@Cherrg Cherrg commented Jun 20, 2019 •
edited
Loading

  • fixes tables in dark theme
  • fix simpleMDE preview in dark theme

Images

OLD NEW
Tables in Markdown
Commit 1		 grafik grafik
Markdown editor wiki + repo
Commit 2		 grafik grafik

Signed-off-by: Michael Gnehr [email protected]

@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Jun 20, 2019
@codecov-io
Copy link

codecov-io commented Jun 20, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@a25b3d4). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7260   +/-   ##
=========================================
  Coverage          ?   40.99%           
=========================================
  Files             ?      462           
  Lines             ?    62584           
  Branches          ?        0           
=========================================
  Hits              ?    25654           
  Misses            ?    33567           
  Partials          ?     3363

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a25b3d4...500faa3. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 20, 2019
@silverwind
Copy link
Member

The scrollbar styling is Firefox-only as of now. Maybe we want to add site-wide dark scrollbars to the dark theme?

See here for cross-browser scrollbar styling.

@lafriks lafriks added this to the 1.9.0 milestone Jun 20, 2019
@lafriks
Copy link
Member

lafriks commented Jun 20, 2019

@silverwind that should probably be done in other PR

@silverwind
Copy link
Member

Then I suggest removing this non-portable scrollbar style here.

lafriks
lafriks requested changes Jun 20, 2019
View reviewed changes
Copy link
Member

@lafriks lafriks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be globally added to all scrollbars and made portable but I would better see this done in other PR

public/less/themes/arc-green.less Outdated Show resolved Hide resolved
public/css/theme-arc-green.css Outdated Show resolved Hide resolved
@Cherrg
Copy link
Contributor Author

Cherrg commented Jun 20, 2019 •
edited
Loading

I will remove the FF scroolbar line there.
I had added FF Scrollbar, as Chrome already got an colored scrollbar by semantic.css. FF was missing. (May This) (And Scrollbar was last thing with wrong color.)
You right lets do this globally on different PR.

Edit:

  • FF scrollbar theming is relative new (since FFv63 by conf flag)
  • Chrome (webkit) scrollbar is semi transparent, so color will change if bg color changes. So editor looks ok. Scrollbar of main container (html/body) has no color in dark theme too.

@Cherrg @lafriks
Update public/less/themes/arc-green.less
2304949 
remove scroll bar color, to add this globally on additional PR

Co-Authored-By: Lauris BH <[email protected]>
Signed-off-by: Michael Gnehr <[email protected]>
@Cherrg Cherrg mentioned this pull request Jun 20, 2019
Merged
@Cherrg
Copy link
Contributor Author

Cherrg commented Jun 20, 2019

done, even created seperate PR for dark theme scrollbars: #7269

@Cherrg
add missing class name
fdaeddb 
Signed-off-by: Michael Gnehr <[email protected]>
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 21, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 21, 2019
@Cherrg
Copy link
Contributor Author

Cherrg commented Jun 21, 2019

Please restart drone build. Ty

@lunny lunny merged commit d145955 into go-gitea:master Jun 21, 2019
@Cherrg Cherrg deleted the dark_theme_markdown_fix branch June 28, 2019 03:29
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@Cherrg @jeffliu27
Dark theme markdown fixes (go-gitea#7260)
61432b4 
* fix colors in dark theme - tables inside rendered markdown

Signed-off-by: Michael Gnehr <[email protected]>

* fix colors in dark theme - simpleMDE rendered preview

Signed-off-by: Michael Gnehr <[email protected]>

* Update public/less/themes/arc-green.less

remove scroll bar color, to add this globally on additional PR

Co-Authored-By: Lauris BH <[email protected]>
Signed-off-by: Michael Gnehr <[email protected]>

* add missing class name

Signed-off-by: Michael Gnehr <[email protected]>
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sapk sapk sapk approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
7 participants
@Cherrg @codecov-io @silverwind @lafriks @sapk @lunny @GiteaBot