Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow colon between fixing word and issue #7207

Merged
merged 2 commits into from
Jun 15, 2019
Merged

Allow colon between fixing word and issue #7207

merged 2 commits into from
Jun 15, 2019

Conversation

zeripath
Copy link
Contributor

Fixes: #7202

@techknowlogick techknowlogick added this to the 1.9.0 milestone Jun 14, 2019
@codecov-io
Copy link

codecov-io commented Jun 14, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@9ce4d89). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7207   +/-   ##
=========================================
  Coverage          ?   41.53%           
=========================================
  Files             ?      449           
  Lines             ?    61306           
  Branches          ?        0           
=========================================
  Hits              ?    25463           
  Misses            ?    32491           
  Partials          ?     3352
Impacted Files Coverage Δ
models/action.go 58.77% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9ce4d89...f108021. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 14, 2019
@mrsdizzie
Copy link
Member

Maybe add a test, or just stick a colon in one of the several tests here?

gitea/models/action_test.go

Line 187 in 9ce4d89

func TestUpdateIssuesCommit(t *testing.T) {

@zeripath
Copy link
Contributor Author

OK done

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 14, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 15, 2019
@techknowlogick techknowlogick merged commit 94ceaf1 into go-gitea:master Jun 15, 2019
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@zeripath @jeffliu27
Allow colon between fixing word and issue (go-gitea#7207)
6672018 
* Allow colon between fixing word and issue

* update test
This was referenced Sep 8, 2019
Merged
Closed
@zeripath zeripath deleted the fix-7202-allow-colon-between-fixing-words branch October 16, 2019 15:16
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser approved these changes

@mrsdizzie mrsdizzie mrsdizzie approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

'Fixes: #id' in commit message does not close issues
6 participants
@zeripath @codecov-io @mrsdizzie @jolheiser @techknowlogick @GiteaBot