Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pusher name via ssh push #7167

Merged
merged 2 commits into from
Jun 11, 2019
Merged

Conversation

lunny
Copy link
Member

@lunny lunny commented Jun 10, 2019

Will fix #7150, @silverwind @kolaente please confirm.

@lunny lunny added the type/bug label Jun 10, 2019
@lunny lunny added this to the 1.9.0 milestone Jun 10, 2019
@codecov-io
Copy link

codecov-io commented Jun 10, 2019

Codecov Report

Merging #7167 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #7167      +/-   ##
==========================================
- Coverage   41.73%   41.73%   -0.01%     
==========================================
  Files         449      449              
  Lines       61112    61112              
==========================================
- Hits        25505    25503       -2     
- Misses      32294    32297       +3     
+ Partials     3313     3312       -1
Impacted Files Coverage Δ
models/unit.go 62.16% <0%> (-5.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3b4684...b0451f3. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 10, 2019
@silverwind
Copy link
Member

Working, thanks. It does not fix old pushers, but it's not really neccesary.

image

@lunny
Copy link
Member Author

lunny commented Jun 10, 2019

@silverwind old wrong pusher has been written to database and that real pusher lost and cannot be recovered.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 10, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 10, 2019
@lunny lunny merged commit 74690f6 into go-gitea:master Jun 11, 2019
@lunny lunny deleted the lunny/fix_pusher_name_ssh branch June 11, 2019 01:13
@zeripath
Copy link
Contributor

oh sorry about that. I don't know how that sneaked by me.

jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pushes to Org repo show the Org itself pushing in the dashboard
7 participants