chore: change issue mail title. #7064
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Bo-Yi Wu <[email protected]>
adelowo
approved these changes
May 28, 2019
GiteaBot
added
the
lgtm/need 1
Codecov Report
@@ Coverage Diff @@
## master #7064 +/- ##
==========================================
- Coverage 41.44% 41.43% -0.01%
==========================================
Files 442 442
Lines 59643 59643
==========================================
- Hits 24717 24714 -3
- Misses 31696 31699 +3
Partials 3230 3230
Continue to review full report at Codecov.
|
lunny
requested changes
May 28, 2019
models/issue_mail.go
Outdated
| @@ -16,7 +16,7 @@ import ( | |||
| ) | |||
|
|
|||
| func (issue *Issue) mailSubject() string { | |||
| return fmt.Sprintf("[%s] %s (#%d)", issue.Repo.Name, issue.Title, issue.Index) | |||
| return fmt.Sprintf("[%s/%s] %s (#%d)", issue.Repo.OwnerName, issue.Repo.Name, issue.Title, issue.Index) | |||
There was a problem hiding this comment.
Could you confirm .OwnerName has been filled?
zeripath
reviewed
May 28, 2019
models/issue_mail.go
Outdated
| @@ -16,7 +16,7 @@ import ( | |||
| ) | |||
|
|
|||
| func (issue *Issue) mailSubject() string { | |||
| return fmt.Sprintf("[%s] %s (#%d)", issue.Repo.Name, issue.Title, issue.Index) | |||
| return fmt.Sprintf("[%s/%s] %s (#%d)", issue.Repo.OwnerName, issue.Repo.Name, issue.Title, issue.Index) | |||
There was a problem hiding this comment.
Are we sure that Repo.OwnerName is definitely set? If not we might need:
Suggested change
| return fmt.Sprintf("[%s/%s] %s (#%d)", issue.Repo.OwnerName, issue.Repo.Name, issue.Title, issue.Index) | |
| return fmt.Sprintf("[%s/%s] %s (#%d)", issue.Repo.MustOwnerName(), issue.Repo.Name, issue.Title, issue.Index) |
But then you need to check that we're not in a session otherwise we might deadlock.
Signed-off-by: Bo-Yi Wu <[email protected]>
lunny
approved these changes
May 28, 2019
GiteaBot
added
lgtm/done
zeripath
approved these changes
May 28, 2019
jeffliu27
pushed a commit
to jeffliu27/gitea
that referenced
this pull request
Jul 18, 2019
* chore: change issue mail title. Signed-off-by: Bo-Yi Wu <[email protected]> * change to fullname method Signed-off-by: Bo-Yi Wu <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See: https://gitea.com/gitea/log/issues/9
before:
after: