Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use batch insert on migrating repository to make the process faster #7050

Merged
merged 11 commits into from
Jun 29, 2019
Merged

Use batch insert on migrating repository to make the process faster #7050

merged 11 commits into from
Jun 29, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented May 26, 2019 •
edited
Loading

depend on #7049

This PR changed all the upload interface from single record to batch records to make migration faster than before.

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label May 26, 2019
@lunny lunny force-pushed the lunny/batch_migration_upload branch from a23cff3 to 809e146 Compare May 31, 2019 03:43
@codecov-io
Copy link

codecov-io commented May 31, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@e463bda). Click here to learn what that means.
The diff coverage is 0.35%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #7050   +/-   ##
=========================================
  Coverage          ?   41.19%           
=========================================
  Files             ?      464           
  Lines             ?    62938           
  Branches          ?        0           
=========================================
  Hits              ?    25928           
  Misses            ?    33617           
  Partials          ?     3393
Impacted Files Coverage Δ
modules/migrations/gitea.go 7.57% <0%> (ø)
modules/migrations/migrate.go 20.77% <0%> (ø)
models/migrate.go 0% <0%> (ø)
modules/migrations/github.go 84.05% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e463bda...aa2f969. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 31, 2019
@lunny lunny added this to the 1.9.0 milestone May 31, 2019
@lunny
Copy link
Member Author

lunny commented May 31, 2019

Ready to review

@lunny lunny force-pushed the lunny/batch_migration_upload branch from 117f3fd to cc755bb Compare May 31, 2019 13:58
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 25, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 28, 2019
@lunny lunny merged commit 462284e into go-gitea:master Jun 29, 2019
@lunny lunny deleted the lunny/batch_migration_upload branch June 29, 2019 13:38
@lunny lunny mentioned this pull request Jul 1, 2019
Merged
@mrsdizzie mrsdizzie mentioned this pull request Jul 3, 2019
Closed
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@lunny @jeffliu27
Use batch insert on migrating repository to make the process faster (g…
6ff10ab 
…o-gitea#7050)

* Use batch insert on migrating repository to make the process faster

* fix lint

* fix tests

* fix comments
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@lunny @codecov-io @techknowlogick @zeripath @GiteaBot