Webhook Logs show proper HTTP Method, and allow change HTTP method in form #6953
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
techknowlogick
commented
May 14, 2019
| @@ -98,6 +98,7 @@ func addHook(ctx *context.APIContext, form *api.CreateHookOption, orgID, repoID | |||
| URL: form.Config["url"], | |||
| ContentType: models.ToHookContentType(form.Config["content_type"]), | |||
| Secret: form.Config["secret"], | |||
| HTTPMethod: "POST", | |||
There was a problem hiding this comment.
Note: I've hardcoded this as POST for now. Currently there are several checks that essentially force POST to be the method, but I want to keep this PR as simple as possible. This of course will need to be changed in future.
GiteaBot
added
the
lgtm/need 2
techknowlogick
commented
May 14, 2019
| @@ -755,28 +755,23 @@ func prepareWebhooks(e Engine, repo *Repository, event HookEventType, p api.Payl | |||
|
|
|||
| func (t *HookTask) deliver() { | |||
| t.IsDelivered = true | |||
| t.RequestInfo = &HookRequest{ | |||
There was a problem hiding this comment.
I've moving these back to the original spot before the GET PR was merged.
Codecov Report
@@ Coverage Diff @@
## master #6953 +/- ##
=========================================
+ Coverage 41.4% 41.4% +<.01%
=========================================
Files 441 441
Lines 59718 59724 +6
=========================================
+ Hits 24728 24731 +3
- Misses 31753 31756 +3
Partials 3237 3237
Continue to review full report at Codecov.
|
techknowlogick
changed the title
zeripath
approved these changes
May 15, 2019
GiteaBot
added
lgtm/need 1
lafriks
approved these changes
May 15, 2019
GiteaBot
added
lgtm/done
lunny
approved these changes
May 15, 2019
jeffliu27
pushed a commit
to jeffliu27/gitea
that referenced
this pull request
Jul 18, 2019
… form (go-gitea#6953) * Fix go-gitea#6951 - logs show proper HTTP Method, and allow change HTTP method in form * enforce POST method for webhook * set default if method is empty
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #6951
Note: this doesn't solve issues some users were having with webhooks not sending.