Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove macaron dependent on models #6940

Merged
merged 3 commits into from
May 14, 2019
Merged

Remove macaron dependent on models #6940

merged 3 commits into from
May 14, 2019

Conversation

lunny
Copy link
Member

@lunny lunny commented May 14, 2019

Will fix #6927

@lunny lunny added the type/refactoring Existing code has been cleaned up. There should be no new functionality. label May 14, 2019
@lunny lunny added this to the 1.9.0 milestone May 14, 2019
@codecov-io
Copy link

codecov-io commented May 14, 2019 •
edited
Loading

Codecov Report

Merging #6940 into master will increase coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6940      +/-   ##
==========================================
+ Coverage    41.4%   41.41%   +<.01%     
==========================================
  Files         441      441              
  Lines       59729    59729              
==========================================
+ Hits        24732    24736       +4     
+ Misses      31760    31755       -5     
- Partials     3237     3238       +1
Impacted Files Coverage Δ
models/mail.go 26.49% <ø> (ø) ⬆️
models/login_source.go 26.98% <0%> (ø) ⬆️
modules/log/file.go 75.52% <0%> (-2.1%) ⬇️
modules/log/event.go 64.46% <0%> (-1.53%) ⬇️
routers/repo/view.go 43.03% <0%> (+1.01%) ⬆️
modules/log/colors_router.go 87.5% <0%> (+4.16%) ⬆️
models/unit.go 67.56% <0%> (+5.4%) ⬆️
modules/avatar/avatar.go 100% <0%> (+18.75%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8b36f01...62cd5f5. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 14, 2019
mrsdizzie
mrsdizzie reviewed May 14, 2019
View reviewed changes
models/login_source.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 14, 2019
@lunny
Copy link
Member Author

lunny commented May 14, 2019

@mrsdizzie done. Just copied from binding...

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 14, 2019
@techknowlogick techknowlogick merged commit 24a536d into go-gitea:master May 14, 2019
@lunny lunny deleted the lunny/remove_models_depend_binding branch May 15, 2019 12:05
jeffliu27 pushed a commit to jeffliu27/gitea that referenced this pull request Jul 18, 2019
@lunny @jeffliu27
Remove macaron dependent on models (go-gitea#6940)
161570f
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mrsdizzie mrsdizzie mrsdizzie approved these changes

@sapk sapk sapk approved these changes

@adelowo adelowo adelowo approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/refactoring Existing code has been cleaned up. There should be no new functionality.
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

models should not depend on macaron
7 participants
@lunny @codecov-io @mrsdizzie @sapk @adelowo @techknowlogick @GiteaBot