-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean less files #6921
Clean less files #6921
Conversation
I think some of the empty lines were removed in a recent PR by @lafriks |
@techknowlogick this is most common usage. easy to find a selector. No empty lines if no selector/ attribute is in between. eg.
i try to get an linter into lessc - it has an plugin (i mostly use sass and a gulp build pipeline). Source map is the next goal. Is only loaded if Development console is open Btw: footer {
.ui.container .left, .ui.container .right {
@media only screen and (max-width: 880px) {
display: block;
text-align: center;
float: none;
}
}
} Single line (and max-depth to avoid very large selectors): footer {
.ui {
&.container {
.left,
.right {
@media only screen and (max-width: 880px) {
display: block;
text-align: center;
float: none;
}
}
}
}
} |
Codecov Report
@@ Coverage Diff @@
## master #6921 +/- ##
==========================================
+ Coverage 41.38% 41.38% +<.01%
==========================================
Files 440 440
Lines 59703 59703
==========================================
+ Hits 24709 24710 +1
Misses 31755 31755
+ Partials 3239 3238 -1
Continue to review full report at Codecov.
|
Sounds good. If you could get that linter in here as well that'd be awesome. Thanks for all your contributions recently. |
@techknowlogick nope, I also added some newlines :) But only in one file that I was changing |
@lafriks ah ok. I just remembered something about empty lines. Thanks for clarification. |
(And maybe add a linter afterwards, new code is more unified, easier to understand)