Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add french specific rule for translating plural texts #6846

Merged
merged 3 commits into from
May 4, 2019
Merged

Add french specific rule for translating plural texts #6846

merged 3 commits into from
May 4, 2019

Conversation

ngourdon
Copy link
Contributor

@ngourdon ngourdon commented May 4, 2019

@techknowlogick techknowlogick added this to the 1.9.0 milestone May 4, 2019
@codecov-io
Copy link

codecov-io commented May 4, 2019 •
edited
Loading

Codecov Report

Merging #6846 into master will decrease coverage by <.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6846      +/-   ##
==========================================
- Coverage   41.19%   41.18%   -0.01%     
==========================================
  Files         423      423              
  Lines       58394    58399       +5     
==========================================
  Hits        24053    24053              
- Misses      31161    31166       +5     
  Partials     3180     3180
Impacted Files Coverage Δ
modules/templates/helper.go 47.95% <0%> (-0.72%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e0dde81...db31952. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 4, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 4, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 4, 2019
@zeripath zeripath merged commit 7806dea into go-gitea:master May 4, 2019
@ngourdon ngourdon deleted the trnlangrules-fr branch June 2, 2019 13:53
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@zeripath zeripath zeripath approved these changes

@sapk sapk sapk approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/translation
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
7 participants
@ngourdon @codecov-io @lafriks @zeripath @sapk @techknowlogick @GiteaBot