Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename LFS_JWT_SECRET cli option to include OAUTH2 as well #6826

Merged
merged 1 commit into from
May 2, 2019
Merged

Rename LFS_JWT_SECRET cli option to include OAUTH2 as well #6826

merged 1 commit into from
May 2, 2019

Conversation

techknowlogick
Copy link
Member

Fix #6810

@techknowlogick techknowlogick added the type/enhancement An improvement of existing functionality label May 2, 2019
@techknowlogick techknowlogick added this to the 1.9.0 milestone May 2, 2019
@techknowlogick techknowlogick changed the title Rename LFS_JWT_SECRET to include OAUTH2 as well Rename LFS_JWT_SECRET cli option to include OAUTH2 as well May 2, 2019
@codecov-io
Copy link

Codecov Report

Merging #6826 into master will decrease coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master   #6826      +/-   ##
=========================================
- Coverage   41.21%   41.2%   -0.01%     
=========================================
  Files         421     421              
  Lines       58118   58118              
=========================================
- Hits        23952   23949       -3     
- Misses      30993   30996       +3     
  Partials     3173    3173
Impacted Files Coverage Δ
modules/log/event.go 64.46% <0%> (-1.53%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e255df8...794ad45. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 2, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 2, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 2, 2019
@techknowlogick techknowlogick merged commit 8979276 into go-gitea:master May 2, 2019
@techknowlogick techknowlogick deleted the fix-6810 branch May 2, 2019 02:32
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sapk sapk sapk approved these changes

@adelowo adelowo adelowo approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

New oauth2.JWT_SECRET is missing from gitea generate secret
5 participants
@techknowlogick @codecov-io @sapk @adelowo @GiteaBot