-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
UI: Tweak tab text and icon colors #6760
Conversation
Updated. Turns out the dark theme already had this hover effect implemented, so I removed the styling there and simplified it a bit. |
Codecov Report
@@ Coverage Diff @@
## master #6760 +/- ##
==========================================
- Coverage 41.22% 41.01% -0.21%
==========================================
Files 421 421
Lines 58064 58050 -14
==========================================
- Hits 23934 23807 -127
- Misses 30962 31076 +114
+ Partials 3168 3167 -1
Continue to review full report at Codecov.
|
Anything blocking the merge here? |
@silverwind once the conflict has been resolved, I can merge this. |
This adds a hover highlight and fades out the icon on inactive tabs.
842e29d
to
d3c1f1d
Compare
It's the damn CSS file as always (#6782), rebased, regenerated and force-pushed. |
Merged. Thanks for your contribution 😄. I will also take this time and suggest to you that you'd make a great candidate for a maintainer of Gitea. One benefit would be you'd be able to provide reviews on other PRs. The only requirement is that you participate in one PR review every few months, or contribute code in the same time frame (which you already meet). I understand it is asking for a minor time commitment, and so please don't feel pressured to accept. |
Guess I can do that. Just put up a PR to add myself to maintainers file? |
@silverwind yup |
This adds a hover highlight and fades out inactive tabs.
Before
After
After (Dark)