Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI: Tweak tab text and icon colors #6760

Merged
merged 1 commit into from
Apr 29, 2019

Conversation

silverwind
Copy link
Member

@silverwind silverwind commented Apr 25, 2019

This adds a hover highlight and fades out inactive tabs.

Before

Screenshot 2019-04-25 at 20 20 43

After

Screenshot 2019-04-25 at 20 34 02

After (Dark)

Screenshot 2019-04-25 at 20 15 07

@silverwind
Copy link
Member Author

Updated. Turns out the dark theme already had this hover effect implemented, so I removed the styling there and simplified it a bit.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 25, 2019
@techknowlogick techknowlogick added the topic/ui Change the appearance of the Gitea UI label Apr 25, 2019
@techknowlogick techknowlogick added this to the 1.9.0 milestone Apr 25, 2019
@codecov-io
Copy link

codecov-io commented Apr 25, 2019

Codecov Report

Merging #6760 into master will decrease coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6760      +/-   ##
==========================================
- Coverage   41.22%   41.01%   -0.21%     
==========================================
  Files         421      421              
  Lines       58064    58050      -14     
==========================================
- Hits        23934    23807     -127     
- Misses      30962    31076     +114     
+ Partials     3168     3167       -1
Impacted Files Coverage Δ
routers/api/v1/org/team.go 3.99% <0%> (-21.6%) ⬇️
models/unit.go 48.64% <0%> (-13.52%) ⬇️
models/access.go 61.78% <0%> (-5.1%) ⬇️
models/org_team.go 50.38% <0%> (-2.87%) ⬇️
routers/api/v1/api.go 68.68% <0%> (-1.75%) ⬇️
models/user.go 51.15% <0%> (+0.09%) ⬆️
modules/setting/setting.go 48.16% <0%> (+0.68%) ⬆️
models/gpg_key.go 56.66% <0%> (+0.83%) ⬆️
modules/log/event.go 65.98% <0%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8d0d7bc...d3c1f1d. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 25, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 25, 2019
@silverwind
Copy link
Member Author

Sorry, had to do one more minor tweak. Inactive tabs are faded out a tiny bit more now (.5 over .6):

Screenshot 2019-04-26 at 13 55 55

@silverwind
Copy link
Member Author

Anything blocking the merge here?

@techknowlogick
Copy link
Member

@silverwind once the conflict has been resolved, I can merge this.

This adds a hover highlight and fades out the icon on inactive tabs.
@silverwind
Copy link
Member Author

silverwind commented Apr 29, 2019

It's the damn CSS file as always (#6782), rebased, regenerated and force-pushed.

@techknowlogick techknowlogick merged commit c64fe09 into go-gitea:master Apr 29, 2019
@techknowlogick
Copy link
Member

Merged. Thanks for your contribution 😄. I will also take this time and suggest to you that you'd make a great candidate for a maintainer of Gitea. One benefit would be you'd be able to provide reviews on other PRs. The only requirement is that you participate in one PR review every few months, or contribute code in the same time frame (which you already meet). I understand it is asking for a minor time commitment, and so please don't feel pressured to accept.

@silverwind
Copy link
Member Author

Guess I can do that. Just put up a PR to add myself to maintainers file?

@techknowlogick
Copy link
Member

@silverwind yup

@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants