Improve issue reference on commit #6694
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow commits to properly reference issues in other repositories and also to close/reopen those issues if user has code permission. Should match Github behavior described here: https://help.github.com/en/articles/closing-issues-using-keywords Fixes 6664
Codecov Report
@@ Coverage Diff @@
## master #6694 +/- ##
=========================================
- Coverage 41.21% 41.2% -0.01%
=========================================
Files 421 421
Lines 58059 58118 +59
=========================================
+ Hits 23930 23949 +19
- Misses 30963 30996 +33
- Partials 3166 3173 +7
Continue to review full report at Codecov.
|
GiteaBot
added
the
lgtm/need 2
zeripath
approved these changes
Apr 20, 2019
There was a problem hiding this comment.
Seems reasonable, just a comment that you could have already had the regexp do the splitting for you.
Finally, just make certain that usernames and repository names don't have different first letter requirements from the rest of their names - I don't think they do but it might be reasonable to check.
GiteaBot
added
lgtm/need 1
techknowlogick
approved these changes
May 1, 2019
GiteaBot
added
lgtm/done
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow commits to properly reference issues in other repositories and also to close/reopen those issues if user has code permission. Should match Github behavior described here: https://help.github.com/en/articles/closing-issues-using-keywords
Fixes #6664
This also fixes a bug I noticed where if you reference another repo in the form of
user/repo#1Gitea will currently just match the#1so if the usergiteacommits a file that saysCloses gogs/gogs#1to the repogitea/giteait will actually close issue#1on the gitea repo