Prevent creating empty sessions #6677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andrew Thornton <[email protected]>
lunny
requested changes
Apr 19, 2019
GiteaBot
added
lgtm/need 2
zeripath
commented
Apr 19, 2019
Signed-off-by: Andrew Thornton <[email protected]>
…/gitea into prevent-creating-empty-sessions
Codecov Report
@@ Coverage Diff @@
## master #6677 +/- ##
=========================================
Coverage ? 40.87%
=========================================
Files ? 420
Lines ? 57454
Branches ? 0
=========================================
Hits ? 23486
Misses ? 30841
Partials ? 3127
Continue to review full report at Codecov.
|
|
Could you add some integration tests to confirm the unlogin page didn't create session but logined page did? |
|
@lunny it seems that's not an easy thing to do. Our integration tests run with the memory session provider which does not appear to be interrogatable. However, I've done it. |
Signed-off-by: Andrew Thornton <[email protected]>
|
Tests are up. And they broke the rest of the tests... That'll teach me to just test the single tests themselves... |
Signed-off-by: Andrew Thornton <[email protected]>
|
Tests now working. |
techknowlogick
approved these changes
Apr 19, 2019
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Apr 20, 2019
GiteaBot
added
lgtm/done
|
@zeripath thanks |
zeripath
added a commit
to zeripath/gitea
that referenced
this pull request
Apr 20, 2019
* Prevent creating empty sessions Signed-off-by: Andrew Thornton <[email protected]> * Update modules/setting/session.go * Remove unnecessary option Signed-off-by: Andrew Thornton <[email protected]> * Add destory to list of ignored misspellings * rename cookie.go -> virtual.go * Delete old file * Add test to ensure that sessions are not created without being logged in Signed-off-by: Andrew Thornton <[email protected]> * fix tests Signed-off-by: Andrew Thornton <[email protected]> * Update integrations/create_no_session_test.go
zeripath
added a commit
that referenced
this pull request
Apr 20, 2019
Backport #6677 Signed-off-by: Andrew Thornton <[email protected]>
techknowlogick
added
the
backport/done
techknowlogick
added a commit
that referenced
this pull request
Jun 5, 2020
* Dump: Use mholt/archive/v3 to support tar including many compressions Signed-off-by: Philipp Homann <[email protected]> * Dump: Allow dump output to stdout Signed-off-by: Philipp Homann <[email protected]> * Dump: Fixed bug present since #6677 where SessionConfig.Provider is never "file" Signed-off-by: Philipp Homann <[email protected]> * Dump: never pack RepoRootPath, LFS.ContentPath and LogRootPath when they are below AppDataPath Signed-off-by: Philipp Homann <[email protected]> * Dump: also dump LFS (fixes #10058) Signed-off-by: Philipp Homann <[email protected]> * Dump: never dump CustomPath if CustomPath is a subdir of or equal to AppDataPath (fixes #10365) Signed-off-by: Philipp Homann <[email protected]> * Use log.Info instead of fmt.Fprintf Signed-off-by: Philipp Homann <[email protected]> * import ordering * make fmt Co-authored-by: zeripath <[email protected]> Co-authored-by: techknowlogick <[email protected]> Co-authored-by: Matti R <[email protected]>
ydelafollye
pushed a commit
to ydelafollye/gitea
that referenced
this pull request
Jul 31, 2020
* Dump: Use mholt/archive/v3 to support tar including many compressions Signed-off-by: Philipp Homann <[email protected]> * Dump: Allow dump output to stdout Signed-off-by: Philipp Homann <[email protected]> * Dump: Fixed bug present since go-gitea#6677 where SessionConfig.Provider is never "file" Signed-off-by: Philipp Homann <[email protected]> * Dump: never pack RepoRootPath, LFS.ContentPath and LogRootPath when they are below AppDataPath Signed-off-by: Philipp Homann <[email protected]> * Dump: also dump LFS (fixes go-gitea#10058) Signed-off-by: Philipp Homann <[email protected]> * Dump: never dump CustomPath if CustomPath is a subdir of or equal to AppDataPath (fixes go-gitea#10365) Signed-off-by: Philipp Homann <[email protected]> * Use log.Info instead of fmt.Fprintf Signed-off-by: Philipp Homann <[email protected]> * import ordering * make fmt Co-authored-by: zeripath <[email protected]> Co-authored-by: techknowlogick <[email protected]> Co-authored-by: Matti R <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Andrew Thornton [email protected]