Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OAuth2 Grant UI #6625

Merged
merged 15 commits into from
Apr 17, 2019
Merged

OAuth2 Grant UI #6625

merged 15 commits into from
Apr 17, 2019

Conversation

jonasfranz
Copy link
Member

This PR adds the ability of revoking access for certain application via the settings UI.

Screenshots:

Screenshot_2019-04-15 Gitea Git with a cup of tea

@jonasfranz jonasfranz added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Apr 15, 2019
@jonasfranz jonasfranz added this to the 1.9.0 milestone Apr 15, 2019
jonasfranz and others added 2 commits April 15, 2019 09:17
@jonasfranz
Fix unit tests
e2736a1 
Signed-off-by: Jonas Franz <[email protected]>
@jonasfranz
Fix unit tests
5176ebe 
Signed-off-by: Jonas Franz <[email protected]>
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 15, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 15, 2019
@codecov-io
Copy link

codecov-io commented Apr 15, 2019 •
edited
Loading

Codecov Report

Merging #6625 into master will increase coverage by <.01%.
The diff coverage is 54%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6625      +/-   ##
==========================================
+ Coverage   40.75%   40.76%   +<.01%     
==========================================
  Files         407      407              
  Lines       54680    54730      +50     
==========================================
+ Hits        22284    22308      +24     
- Misses      29344    29368      +24     
- Partials     3052     3054       +2
Impacted Files Coverage Δ
routers/user/setting/oauth2.go 0% <0%> (ø) ⬆️
routers/routes/routes.go 81.99% <100%> (+0.02%) ⬆️
routers/user/setting/applications.go 45.61% <20%> (-2.47%) ⬇️
models/oauth2_application.go 58.78% <80.64%> (+2.73%) ⬆️
models/unit.go 0% <0%> (-14.29%) ⬇️
routers/repo/view.go 41.08% <0%> (-1%) ⬇️
modules/log/event.go 65.98% <0%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3454836...833e03d. Read the comment docs.

lunny
lunny requested changes Apr 15, 2019
View reviewed changes
routers/routes/routes.go Outdated Show resolved Hide resolved
models/oauth2_application.go Show resolved Hide resolved
@jonasfranz
Refactor DeleteOAuth2Grant
dcfcaa9 
Use results.Close()

Signed-off-by: Jonas Franz <[email protected]>
@jonasfranz jonasfranz requested a review from lunny April 15, 2019 20:30
lunny
lunny reviewed Apr 16, 2019
View reviewed changes
models/oauth2_application.go Outdated Show resolved Hide resolved
@jonasfranz jonasfranz requested a review from lunny April 16, 2019 07:39
@jonasfranz jonasfranz requested a review from lunny April 17, 2019 06:33
@lunny
Copy link
Member

lunny commented Apr 17, 2019 •
edited
Loading

@jonasfranz I mean ctx.QueryInt64("id") maybe zero, but not ctx.User.ID. If ctx.QueryInt64("id") is zero will delete all grants.

@jonasfranz
Check if grant ID is zero
d704744 
Signed-off-by: Jonas Franz <[email protected]>
@jonasfranz
Copy link
Member Author

@lunny fixed

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 17, 2019
@lunny lunny merged commit 7a4c29c into go-gitea:master Apr 17, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kolaente kolaente kolaente approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/feature Completely new functionality. Can only be merged if feature freeze is not active.
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@jonasfranz @codecov-io @lunny @kolaente @GiteaBot