-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add .gpg url (match github behaviour) #6610
Conversation
@sapk Thanks for continuing this PR 😃 |
Co-Authored-By: sapk <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #6610 +/- ##
==========================================
+ Coverage 40.47% 40.48% +<.01%
==========================================
Files 405 406 +1
Lines 54388 54484 +96
==========================================
+ Hits 22012 22056 +44
- Misses 29349 29390 +41
- Partials 3027 3038 +11
Continue to review full report at Codecov.
|
@sapk @techknowlogick good work. With integration tests are better. |
@lunny done |
After some testing of #4193 I added what was missing to have it working. Thx to @techknowlogick that lay down most of the bases.
Basically, we haven't in database what is needed to fully reconstruct the gpg armored export (ex: signature, full identities, ...).
I add a table containing the imported armored key that we can re-used to be join with others imported keys and exported.
Like github previous keys that need re-import are marked as a header (ex: https://github.com/sapk.gpg)
The only bug is that the cipherTypeByte are changed by the export by golang compared to the imported one but that doesn't change the interpretation of the gpg armored key.