-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show "delete branch" button on closed pull requests (#6570) #6601
Show "delete branch" button on closed pull requests (#6570) #6601
Conversation
…been closed (go-gitea#6570) Signed-off-by: Mario Lubenka <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #6601 +/- ##
=========================================
Coverage ? 40.78%
=========================================
Files ? 421
Lines ? 57571
Branches ? 0
=========================================
Hits ? 23480
Misses ? 30965
Partials ? 3126
Continue to review full report at Codecov.
|
What needs to be done in order to merge this? :) |
@saitho need two maintainers' approvals. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit - I think it makes the comment clearer.
Co-Authored-By: saitho <[email protected]>
…closed_pull_requests
…closed_pull_requests
Resolves #6570
Note that these changes introduce a new behaviour:
Closed pull requests whose pull branch was deleted can't be reopened by the user anymore.