Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show "delete branch" button on closed pull requests (#6570) #6601

Conversation

saitho
Copy link
Contributor

@saitho saitho commented Apr 13, 2019

Resolves #6570

Note that these changes introduce a new behaviour:
Closed pull requests whose pull branch was deleted can't be reopened by the user anymore.

@codecov-io
Copy link

codecov-io commented Apr 13, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@b1bb700). Click here to learn what that means.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6601   +/-   ##
=========================================
  Coverage          ?   40.78%           
=========================================
  Files             ?      421           
  Lines             ?    57571           
  Branches          ?        0           
=========================================
  Hits              ?    23480           
  Misses            ?    30965           
  Partials          ?     3126
Impacted Files Coverage Δ
routers/repo/issue.go 37.15% <100%> (ø)
routers/repo/pull.go 36.67% <50%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b1bb700...afdeea8. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 13, 2019
@saitho saitho marked this pull request as ready for review April 13, 2019 11:46
@saitho
Copy link
Contributor Author

saitho commented Apr 20, 2019

What needs to be done in order to merge this? :)

@lunny lunny added this to the 1.9.0 milestone Apr 20, 2019
@lunny lunny added the type/enhancement An improvement of existing functionality label Apr 20, 2019
@lunny
Copy link
Member

lunny commented Apr 20, 2019

@saitho need two maintainers' approvals.

Copy link
Contributor

@zeripath zeripath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small nit - I think it makes the comment clearer.

routers/repo/pull.go Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 20, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 20, 2019
@lafriks lafriks merged commit bc86134 into go-gitea:master Apr 20, 2019
@saitho saitho deleted the feature/6570-Option_to_remove_branches_of_closed_pull_requests branch April 28, 2019 10:19
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/enhancement An improvement of existing functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

When closing a pull request, it should ask if the branch should be deleted
6 participants