Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correctly adjust mirror url #6593

Merged
merged 2 commits into from
Apr 12, 2019
Merged

Correctly adjust mirror url #6593

merged 2 commits into from
Apr 12, 2019

Conversation

zeripath
Copy link
Contributor

No description provided.

@techknowlogick techknowlogick added this to the 1.9.0 milestone Apr 12, 2019
kolaente
kolaente reviewed Apr 12, 2019
View reviewed changes
Copy link
Member

@kolaente kolaente left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit, looks good otherwise.

routers/repo/setting.go Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 12, 2019
@codecov-io
Copy link

codecov-io commented Apr 12, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@01e0408). Click here to learn what that means.
The diff coverage is 8.16%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6593   +/-   ##
=========================================
  Coverage          ?   40.47%           
=========================================
  Files             ?      405           
  Lines             ?    54388           
  Branches          ?        0           
=========================================
  Hits              ?    22015           
  Misses            ?    29346           
  Partials          ?     3027
Impacted Files Coverage Δ
models/repo_mirror.go 23.65% <0%> (ø)
routers/repo/setting.go 10.07% <10%> (ø)
models/repo.go 46.92% <33.33%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 01e0408...c971b1f. Read the comment docs.

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 12, 2019
jolheiser
jolheiser approved these changes Apr 12, 2019
View reviewed changes
Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works with my local tests. 👍

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 12, 2019
@zeripath zeripath merged commit b3e757a into go-gitea:master Apr 12, 2019
@zeripath zeripath deleted the fix-mirror branch April 12, 2019 20:53
zeripath added a commit to zeripath/gitea that referenced this pull request Apr 12, 2019
@zeripath
Correctly adjust mirror url (go-gitea#6593)
8d8848c
zeripath added a commit to zeripath/gitea that referenced this pull request Apr 12, 2019
@zeripath
Correctly adjust mirror url (go-gitea#6593)
52af826
zeripath added a commit that referenced this pull request Apr 12, 2019
@zeripath
Correctly adjust mirror url (#6593) (#6594)
40f41dc
techknowlogick pushed a commit that referenced this pull request Apr 13, 2019
@zeripath @techknowlogick
Correctly adjust mirror url (#6593) (#6595)
bac388d
@yasuokav yasuokav mentioned this pull request May 1, 2019
Closed
@zeripath zeripath mentioned this pull request May 1, 2019
Merged
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label May 6, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser approved these changes

@kolaente kolaente kolaente approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore.
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
6 participants
@zeripath @codecov-io @kolaente @jolheiser @techknowlogick @GiteaBot