-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix mail notification when close/reopen issue #6581
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6581 +/- ##
==========================================
+ Coverage 40.35% 40.36% +0.01%
==========================================
Files 405 405
Lines 54260 54279 +19
==========================================
+ Hits 21896 21911 +15
- Misses 29349 29351 +2
- Partials 3015 3017 +2
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to internationalise these emails in general.
I think this should be backported, as it's a small, but highly impactful quality of life fix. we are working in a larger team, as such the throughput can be quite high. right now, I have to open every email to see if the ticket was closed or if it's a new ticket/comment. this is quite annoying and having to tell my team it will take some time until this stops isn't something I'm looking forward to. |
Seems reasonable to me that this could be backported. @lunny can we send a backport? |
@zeripath done. |
@femaref The backport is in our release/v1.8 branch now. |
thank you. are there builds available before they are released as rc? or do I have to build it myself? |
will fix #6580