Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes pagination width on mobile view (#5711) #6532

Merged
merged 2 commits into from
Apr 8, 2019

Conversation

saitho
Copy link
Contributor

@saitho saitho commented Apr 7, 2019

Resolves #5711.

On the mobile view port the text labels are removed and the pagination is reduced to only show the selected page.

responsive_pagination

The issue is only fixed for templates that use the paginate template file.
There are cases where this file is not used. Unifying these is part of #6531.

@saitho saitho force-pushed the bug/responsive_pagination branch from 69011a0 to 1659672 Compare April 7, 2019 11:47
@codecov-io
Copy link

codecov-io commented Apr 7, 2019

Codecov Report

Merging #6532 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #6532   +/-   ##
======================================
  Coverage    40.4%   40.4%           
======================================
  Files         404     404           
  Lines       54140   54140           
======================================
  Hits        21874   21874           
  Misses      29250   29250           
  Partials     3016    3016

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa02463...aff4853. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 7, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 7, 2019
@zeripath zeripath added the topic/ui Change the appearance of the Gitea UI label Apr 7, 2019
@zeripath zeripath added this to the 1.9.0 milestone Apr 7, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 8, 2019
@lafriks lafriks merged commit 6e4af49 into go-gitea:master Apr 8, 2019
@saitho saitho deleted the bug/responsive_pagination branch April 28, 2019 10:19
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Pagination doesn't wrap on lesser window width
5 participants