Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

UI: Use regular line-height on frontpage entries #6518

Merged
merged 3 commits into from
Apr 6, 2019
Merged

UI: Use regular line-height on frontpage entries #6518

merged 3 commits into from
Apr 6, 2019

Conversation

silverwind
Copy link
Member

This changes the paragraphs on frontpage to use the default line-heightof 1.4285em instead of 1em which looked cramped and unnatural to me.

Before

Screenshot 2019-04-05 at 09 28 44

After

Screenshot 2019-04-05 at 09 28 55

@codecov-io
Copy link

codecov-io commented Apr 5, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@d1b8840). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6518   +/-   ##
=========================================
  Coverage          ?   40.26%           
=========================================
  Files             ?      403           
  Lines             ?    54079           
  Branches          ?        0           
=========================================
  Hits              ?    21774           
  Misses            ?    29287           
  Partials          ?     3018

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1b8840...92ac7b9. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 5, 2019
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Apr 5, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 5, 2019
@lafriks lafriks added this to the 1.9.0 milestone Apr 5, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 5, 2019
@techknowlogick techknowlogick merged commit 7ed65a9 into go-gitea:master Apr 6, 2019
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jolheiser jolheiser jolheiser approved these changes

@lafriks lafriks lafriks approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
7 participants
@silverwind @codecov-io @lafriks @jolheiser @techknowlogick @GiteaBot @zeripath