Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some logging documentation #6498

Merged
merged 7 commits into from
Apr 4, 2019
Merged

Some logging documentation #6498

merged 7 commits into from
Apr 4, 2019

Conversation

zeripath
Copy link
Contributor

@zeripath zeripath commented Apr 2, 2019

Following the merging of #6095 I think its reasonable to add some specific information about logging in the post 1.9 world.

jolheiser
jolheiser requested changes Apr 2, 2019
View reviewed changes
Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few wording nits.

docs/content/doc/advanced/logging-documentation.en-us.md Outdated Show resolved Hide resolved
docs/content/doc/advanced/logging-documentation.en-us.md Outdated Show resolved Hide resolved
docs/content/doc/advanced/logging-documentation.en-us.md Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 2, 2019
jolheiser
jolheiser reviewed Apr 2, 2019
View reviewed changes
Copy link
Member

@jolheiser jolheiser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more things I noticed.

docs/content/doc/advanced/logging-documentation.en-us.md Outdated Show resolved Hide resolved
docs/content/doc/advanced/logging-documentation.en-us.md Outdated Show resolved Hide resolved
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 3, 2019
@codecov-io
Copy link

codecov-io commented Apr 3, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@8fcbfa7). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6498   +/-   ##
=========================================
  Coverage          ?   40.27%           
=========================================
  Files             ?      403           
  Lines             ?    54069           
  Branches          ?        0           
=========================================
  Hits              ?    21778           
  Misses            ?    29273           
  Partials          ?     3018

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8fcbfa7...fbca143. Read the comment docs.

@lafriks lafriks added the type/docs This PR mainly updates/creates documentation label Apr 4, 2019
@lafriks lafriks added this to the 1.9.0 milestone Apr 4, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 4, 2019
@zeripath zeripath merged commit 059b527 into go-gitea:master Apr 4, 2019
@zeripath zeripath deleted the logging-documentation branch April 4, 2019 08:44
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks approved these changes

@jolheiser jolheiser jolheiser approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/docs This PR mainly updates/creates documentation
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.
5 participants
@zeripath @codecov-io @lafriks @jolheiser @GiteaBot