Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repo sub_menu font color in arc-green #6477

Merged
merged 3 commits into from
Apr 2, 2019

Conversation

jolheiser
Copy link
Member

As discussed in Discord, this PR fixes the coloring of the active tab in a repo.

Before
active_tab_color

After
Screenshot from 2019-03-31 23-03-25

As for actual changes, I opted to add the ui class to the link, which breaks it from the CSS that styled it black beforehand. Perhaps an explicit override in arc-green.css would also make sense, but this seemed to be the simplest fix without altering existing styles.

@codecov-io
Copy link

codecov-io commented Apr 1, 2019

Codecov Report

Merging #6477 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #6477      +/-   ##
==========================================
+ Coverage   39.39%   39.39%   +<.01%     
==========================================
  Files         393      393              
  Lines       53271    53271              
==========================================
+ Hits        20986    20988       +2     
+ Misses      29299    29297       -2     
  Partials     2986     2986
Impacted Files Coverage Δ
models/repo_list.go 67.89% <0%> (+1.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5c4b961...2880357. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Apr 1, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Apr 1, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 1, 2019
@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Apr 1, 2019
@lafriks lafriks added this to the 1.9.0 milestone Apr 1, 2019
@lunny lunny merged commit b04a1d9 into go-gitea:master Apr 2, 2019
@jolheiser jolheiser deleted the active_tab_color branch April 12, 2019 15:59
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants