-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API for manipulating Git hooks #6436
Conversation
Signed-off-by: Segev Finer <[email protected]>
ea00b1f
to
3636a2f
Compare
Refreshed the PR with changes from master. The added |
@segevfiner I've just merged the SDK code. You can now update this PR with appropriate changes :) |
This looks great! Thanks for PR 😄 Could you add some tests (ensure that githooks update after change, simple fetch of githooks return expected content, error when user who doesn't have access to githooks tries to access)? |
Codecov Report
@@ Coverage Diff @@
## master #6436 +/- ##
=========================================
+ Coverage 40.53% 40.74% +0.2%
=========================================
Files 406 407 +1
Lines 54506 54680 +174
=========================================
+ Hits 22095 22278 +183
+ Misses 29373 29351 -22
- Partials 3038 3051 +13
Continue to review full report at Codecov.
|
@techknowlogick I want to add a Git hook to one of the fixture repos to test list/get, but to which one of the fixture repos should I add it too? Maybe a new one? |
Looking at recent PR you can re-use the same repo (or add another similar) introduce in #6479 |
I added a bunch of tests. EDIT: Whooops, build failure, will fix soon. |
Co-Authored-By: segevfiner <[email protected]>
Co-Authored-By: segevfiner <[email protected]>
❗️ Depends on go-gitea/go-sdk#156 (merged)
❗️ Depends on go-gitea/git#151 (merged)
(
Depgo.mod
must be updated when those are merged as I made it point to our fork for this to build)This adds API for manipulating Git hooks which are only accessible via a web form ATM.