Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add title attributes to all items in the repo list viewer #6258

Merged
merged 7 commits into from
Mar 19, 2019
Merged

Add title attributes to all items in the repo list viewer #6258

merged 7 commits into from
Mar 19, 2019

Conversation

jolheiser
Copy link
Member

Resolves #6256

Leaving as a draft for now, going to see if there are more places this should be done as well.

@codecov-io
Copy link

codecov-io commented Mar 6, 2019 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@d1c982c). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #6258   +/-   ##
=========================================
  Coverage          ?   38.87%           
=========================================
  Files             ?      365           
  Lines             ?    51341           
  Branches          ?        0           
=========================================
  Hits              ?    19959           
  Misses            ?    28509           
  Partials          ?     2873

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d1c982c...a1fe457. Read the comment docs.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Mar 6, 2019
@mateusza
Copy link

mateusza commented Mar 9, 2019

I noticed that github put full (multiline) commit message into title="" on the same screen... But I'm not sure if this time we want to have this one too... Might be a little waste of bandwith.

@jolheiser jolheiser marked this pull request as ready for review March 14, 2019 15:03
@jolheiser
Copy link
Member Author

Counting this as ready for review. More enhancements could be made down the road if wanted/needed.

lunny
lunny requested changes Mar 14, 2019
View reviewed changes
templates/repo/view_list.tmpl
@@ -65,7 +65,7 @@
{{$subJumpablePathName := $entry.GetSubJumpablePathName}}
{{$subJumpablePath := SubJumpablePath $subJumpablePathName}}
<span class="octicon octicon-file-directory"></span>
<a href="{{EscapePound $.TreeLink}}/{{EscapePound $subJumpablePathName}}">
<a href="{{EscapePound $.TreeLink}}/{{EscapePound $subJumpablePathName}}" title="{{$subJumpablePathName}}">
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe still EscapePound ?

Copy link
Member Author

@jolheiser jolheiser Mar 14, 2019 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is the title, I don't think it needs to be escaped since EscapePound is for URLs , right?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The template library should automatically ensure that the {{$subJumpablePathName}} is appropriately encoded for attributes.

@lafriks lafriks added the topic/ui Change the appearance of the Gitea UI label Mar 14, 2019
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Mar 16, 2019
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Mar 16, 2019
@techknowlogick techknowlogick merged commit 0b94f10 into go-gitea:master Mar 19, 2019
@jolheiser jolheiser deleted the 6256_long_name_title branch March 19, 2019 02:42
This was referenced Apr 16, 2019
Merged
Closed
@zeripath zeripath added this to the 1.9.0 milestone Apr 16, 2019
@zeripath
Copy link
Contributor

I wonder if this should be backported to 1.8?

jolheiser added a commit to jolheiser/gitea that referenced this pull request Apr 16, 2019
@jolheiser
Add title attributes to all items in the repo list viewer (go-gitea#6258
99294a1 
)
@jolheiser jolheiser mentioned this pull request Apr 16, 2019
Merged
@techknowlogick techknowlogick added the backport/done All backports for this PR have been created label Apr 16, 2019
techknowlogick pushed a commit that referenced this pull request Apr 16, 2019
@jolheiser @techknowlogick
Add title attributes to all items in the repo list viewer (#6258) (#6650
3c21a0e 
)
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@zeripath zeripath zeripath approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.9.0
Development

Successfully merging this pull request may close these issues.

Long filenames are indistinguishable if they are shortened to common substring.
8 participants
@jolheiser @codecov-io @mateusza @zeripath @lunny @techknowlogick @lafriks @GiteaBot