Implement basic file uploads to wiki #6024

gabrielsimoes · 2019-02-09T20:43:06Z

Closes #574

Signed-off-by: Gabriel Silva Simões [email protected]

This allows uploading files to the root of the wiki repo. It doesn't add any deleting feature, but I suppose if a user needs that feature, he/she should be cloning the wiki repo and managing the files there (which is the only way to do that on Github),

Closes #574 Signed-off-by: Gabriel Silva Simões <[email protected]>

codecov-io · 2019-02-09T20:53:09Z

Codecov Report

Merging #6024 into master will decrease coverage by 0.06%.
The diff coverage is 2.29%.

@@            Coverage Diff             @@
##           master    #6024      +/-   ##
==========================================
- Coverage   38.73%   38.66%   -0.07%     
==========================================
  Files         332      332              
  Lines       48992    49079      +87     
==========================================
+ Hits        18976    18977       +1     
- Misses      27269    27354      +85     
- Partials     2747     2748       +1

Impacted Files	Coverage Δ
models/wiki.go	`45.68% <0%> (-16.82%)`	⬇️
modules/auth/repo_form.go	`38.23% <0%> (-0.77%)`	⬇️
routers/repo/wiki.go	`46.35% <0%> (-4.45%)`	⬇️
routers/routes/routes.go	`83.14% <100%> (+0.04%)`	⬆️
modules/process/manager.go	`76.81% <0%> (-4.35%)`	⬇️
models/repo_list.go	`64.55% <0%> (+1.26%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 681345d...c37ec89. Read the comment docs.

zeripath · 2019-02-09T21:48:42Z

models/wiki.go

+	// Copy uploaded files into repository.
+	for _, upload := range uploads {
+		tmpPath := upload.LocalPath()
+		targetPath := path.Join(localPath, upload.Name)


This will allow you to write to arbitrary places in the filesystem. Admittedly you can't overwrite anything with your current code but you can certainly inject into hooks.

Perhaps this could be solved by using the hash of the file path instead of the actual path, in a way similar to what is currently done with avatars (although for avatars it's a hash of the file contents, which I don't think is the best way here).

@guillep2k I think if we look for forbidden pathern this shouldnt be a problem. If we hash files on the wiki wont have a human redable name anymore

allow normal chars a-Z numbers and '-' '_' '.' and add a check for /../ patterns

@6543 but then the users will need to think about how they need to name their files. We should allow them to use any name, as long as it renders a serviceable path from Macaron (i.e. no slashes, no empty string).

zeripath · 2019-02-09T21:51:10Z

routers/repo/wiki.go

+	}
+
+	if err := ctx.Repo.Repository.UploadWikiFiles(ctx.User, strings.TrimSpace(form.Message), form.Files); err != nil {
+		ctx.ServerError("DeleteWikiPage", err)


why DeleteWikiPage

zeripath

Your current code allows for arbitrary insertion of data, and you can't update or delete uploaded data.

lafriks · 2019-02-10T19:24:16Z

@zeripath updating and deletion is out of scope for this PR

zeripath · 2019-02-10T19:51:21Z

The thing is just allowing uploads on the wiki is easy - as this PR shows - it's coming up with the rest of the UI that makes this difficult.

I don't think we should allow uploads without a way to manage these or at least a proposed UI. Saying you can simply git checkout and push from there there isn't really going to answer the problem - you could do that before.

lunny · 2019-03-20T14:29:27Z

After uploaded files, it should be listed some place to easily reference them?

stale · 2019-05-19T15:22:37Z

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs during the next 2 months. Thank you for your contributions.

guillep2k · 2019-09-14T03:08:16Z

models/wiki.go

@@ -22,7 +22,7 @@ import (
 )

 var (
-	reservedWikiNames = []string{"_pages", "_new", "_edit", "raw"}
+	reservedWikiNames = []string{"_pages", "_new", "_edit", "_upload", "raw"}


There should be a migration check or something if we add a new reserved name.

maybe we should reverse all word begin with _. :)

lunny · 2019-09-15T14:48:02Z

Please resolve the conflicts.

6543 · 2019-12-25T17:07:30Z

@gabrielsimoes can you resolve the confilct?

wxiaoguang · 2023-04-25T13:24:12Z

It seems that this PR has been stale for long time, so ...... activate it or close it?

wxiaoguang · 2023-05-01T03:52:34Z

It has been stale for a long time and I can't think of a way to handling it other than closing it. Feel free to reopen if there's any new progress and I could also help.

Implement basic file uploads to wiki

c37ec89

Closes #574 Signed-off-by: Gabriel Silva Simões <[email protected]>

GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Feb 9, 2019

lafriks added the type/feature Completely new functionality. Can only be merged if feature freeze is not active. label Feb 9, 2019

zeripath reviewed Feb 9, 2019

View reviewed changes

zeripath suggested changes Feb 9, 2019

View reviewed changes

techknowlogick added this to the 1.9.0 milestone Feb 9, 2019

stale bot added the issue/stale label May 19, 2019

lunny added the issue/confirmed Issue has been reviewed and confirmed to be present or accepted to be implemented label May 19, 2019

stale bot removed the issue/stale label May 19, 2019

techknowlogick modified the milestones: 1.9.0, 1.10.0 Jun 4, 2019

Cherrg mentioned this pull request Jun 18, 2019

Unify issue and wiki editors #6975

Closed

guillep2k reviewed Sep 14, 2019

View reviewed changes

lunny modified the milestones: 1.10.0, 1.11.0 Sep 27, 2019

lunny modified the milestones: 1.11.0, 1.12.0 Nov 16, 2019

lunny modified the milestones: 1.12.0, 1.x.x May 2, 2020

BLumia mentioned this pull request Jul 20, 2020

[help wanted] Get basic upload-to-wiki working #12279

Closed

ivptr mentioned this pull request Dec 22, 2022

Uploads on the wiki #574

Open

lunny removed this from the 1.x.x milestone Jan 18, 2023

wxiaoguang added the issue/needs-feedback For bugs, we need more details. For features, the feature must be described in more detail label Apr 25, 2023

wxiaoguang closed this May 1, 2023

go-gitea locked as resolved and limited conversation to collaborators Aug 1, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement basic file uploads to wiki #6024

Implement basic file uploads to wiki #6024

gabrielsimoes commented Feb 9, 2019 •

edited

Loading

codecov-io commented Feb 9, 2019

zeripath Feb 9, 2019

guillep2k Sep 14, 2019

6543 Apr 8, 2020

guillep2k Apr 9, 2020

zeripath Feb 9, 2019

zeripath left a comment

lafriks commented Feb 10, 2019

zeripath commented Feb 10, 2019

lunny commented Mar 20, 2019

stale bot commented May 19, 2019

guillep2k Sep 14, 2019

lunny Sep 14, 2019

lunny commented Sep 15, 2019

6543 commented Dec 25, 2019

wxiaoguang commented Apr 25, 2023

wxiaoguang commented May 1, 2023

Implement basic file uploads to wiki #6024

Implement basic file uploads to wiki #6024

Conversation

gabrielsimoes commented Feb 9, 2019 • edited Loading

codecov-io commented Feb 9, 2019

Codecov Report

zeripath Feb 9, 2019

Choose a reason for hiding this comment

guillep2k Sep 14, 2019

Choose a reason for hiding this comment

6543 Apr 8, 2020

Choose a reason for hiding this comment

guillep2k Apr 9, 2020

Choose a reason for hiding this comment

zeripath Feb 9, 2019

Choose a reason for hiding this comment

zeripath left a comment

Choose a reason for hiding this comment

lafriks commented Feb 10, 2019

zeripath commented Feb 10, 2019

lunny commented Mar 20, 2019

stale bot commented May 19, 2019

guillep2k Sep 14, 2019

Choose a reason for hiding this comment

lunny Sep 14, 2019

Choose a reason for hiding this comment

lunny commented Sep 15, 2019

6543 commented Dec 25, 2019

wxiaoguang commented Apr 25, 2023

wxiaoguang commented May 1, 2023

gabrielsimoes commented Feb 9, 2019 •

edited

Loading