Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong text getting saved on editing second comment on an issue. #5608

Merged
merged 2 commits into from
Dec 31, 2018
Merged

Fix wrong text getting saved on editing second comment on an issue. #5608

merged 2 commits into from
Dec 31, 2018

Commits on Dec 29, 2018

  1. comments: Fix an incorrent DOM element selection. 

    This commit fixes a bug that was causing text from previously edited
comment to get saved when two comments were edited one after other.
Text area with id of `#content` isn't unique on the page but it was
being treated as unique by the event handling code.

Fixes: go-gitea#5581.
    @HarshitOnGitHub
    HarshitOnGitHub committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    428960d View commit details
    Browse the repository at this point in the history

  2. templates: Remove id from textarea in commit edit form. 

    An element is assigned an `id` only if it is unique for the whole page
but in this case there can be multiple textarea so it should have one.
    @HarshitOnGitHub
    HarshitOnGitHub committed Dec 29, 2018
    Configuration menu
    Copy the full SHA
    10482fa View commit details
    Browse the repository at this point in the history