Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: replace lint to revive #5422

Merged
merged 2 commits into from
Dec 3, 2018
Merged

refactor: replace lint to revive #5422

merged 2 commits into from
Dec 3, 2018

Conversation

appleboy
Copy link
Member

lint time

$ time make lint
real    0m7.953s
user    0m5.928s
sys     0m2.129s

revive time

$ time make revive
revive -config config.toml -exclude=./vendor/... ./... || exit 1

real    0m5.179s
user    0m8.248s
sys     0m1.785s

@appleboy appleboy added this to the 1.7.0 milestone Nov 28, 2018
@codecov-io
Copy link

codecov-io commented Nov 28, 2018 •
edited
Loading

Codecov Report

Merging #5422 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #5422   +/-   ##
=======================================
  Coverage   37.57%   37.57%           
=======================================
  Files         317      317           
  Lines       46824    46824           
=======================================
  Hits        17593    17593           
  Misses      26732    26732           
  Partials     2499     2499

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2d707fe...8f2247d. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Nov 28, 2018
@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Nov 28, 2018
techknowlogick
techknowlogick reviewed Nov 28, 2018
View reviewed changes
config.toml Outdated Show resolved Hide resolved
Aragur added a commit to Aragur/revive that referenced this pull request Dec 3, 2018
@Aragur
Add gitea to "Who uses Revive"
dcdf1bc 
When merged: go-gitea/gitea#5422 gitea will use revive.
sapk
sapk reviewed Dec 3, 2018
View reviewed changes
Makefile Outdated
@@ -126,12 +126,12 @@ errcheck:
fi
errcheck $(PACKAGES)

.PHONY: lint
lint:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not keep lint command name as it is the action (linting) not the name tool?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sapk revert.

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 3, 2018
@techknowlogick techknowlogick merged commit 20c54f8 into go-gitea:master Dec 3, 2018
mgechev pushed a commit to mgechev/revive that referenced this pull request Dec 4, 2018
@Aragur @mgechev
Add gitea to "Who uses Revive" (#94)
50f3790 
When merged: go-gitea/gitea#5422 gitea will use revive.
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@lafriks lafriks lafriks left review comments

@sapk sapk sapk approved these changes

@techknowlogick techknowlogick techknowlogick approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/code-linting
Projects
None yet
Milestone
1.7.0
Development

Successfully merging this pull request may close these issues.
7 participants
@appleboy @codecov-io @lunny @techknowlogick @lafriks @sapk @bkcsoft