This commit will reduce join star, repo_topic, topic tables on repo search, so that fix extra columns problem on mssql #5136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tests seem to fail |
bkcsoft
added
the
lgtm/need 2
…earch, so that fix extra columns problem on mssql
lunny
force-pushed
the
lunny/fix_mssql_repo_search
branch
from
bd17058 to
0d2dd17
Compare
|
@lafriks The previous test assertion is wrong. See https://github.com/go-gitea/gitea/blob/master/models/fixtures/repo_topic.yml, there is three records and 2 repos which topic name is graphql (id:4) and golang(id:1). So correct results should repo [1, 33], count 2, not [1, 33, 33] count 3. @appleboy |
6 tasks
Codecov Report
@@ Coverage Diff @@
## master #5136 +/- ##
==========================================
- Coverage 37.47% 37.47% -0.01%
==========================================
Files 310 310
Lines 45935 45921 -14
==========================================
- Hits 17216 17209 -7
+ Misses 26242 26237 -5
+ Partials 2477 2475 -2
Continue to review full report at Codecov.
|
lafriks
approved these changes
Oct 30, 2018
bkcsoft
added
lgtm/need 1
techknowlogick
approved these changes
Oct 30, 2018
bkcsoft
added
lgtm/done
|
@lunny please send backport to release/1.6 |
lunny
added a commit
to lunny/gitea
that referenced
this pull request
Oct 31, 2018
…earch, so that fix extra columns problem on mssql (go-gitea#5136) * This commit will reduce join star, repo_topic, topic tables on repo search, so that fix extra columns problem on mssql * fix tests
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit removed join star, repo_topic, topic tables on repo search, so that fix extra columns problem on mssql database. Also, it maybe results in some performance reduce since it used some sub query instead join query.
This will partilly fix #4282.