Fix issue where ecdsa and other key types are not synced from LDAP (#5092)

[xor-gate]

Implements #5092

Currently LDAP sync support only ssh prefixed keytypes, so other keytypes are simply ignored. This PR improves the check by using the native parsing of the public authorized key line. I tried to find out to add a test ecdsa key but not sure where to place it.

I think this are only the calculated fingerprints:

https://github.com/go-gitea/gitea/blob/master/integrations/auth_ldap_test.go#L43-L46

Based on this

https://github.com/go-gitea/gitea/blob/master/integrations/api_admin_test.go
or this
https://github.com/go-gitea/gitea/blob/master/integrations/api_keys_test.go

I would like some advice on the test, as it is highly valuable.

[codecov-io]

Codecov Report

Merging #5094 into master will increase coverage by 0.01%.
The diff coverage is 100%.

@@            Coverage Diff            @@
##           master   #5094      +/-   ##
=========================================
+ Coverage   37.48%   37.5%   +0.01%     
=========================================
  Files         310     310              
  Lines       45922   45923       +1     
=========================================
+ Hits        17215   17223       +8     
+ Misses      26233   26229       -4     
+ Partials     2474    2471       -3

Impacted Files	Coverage Δ
models/user.go	44.64% <100%> (-0.24%)	⬇️
models/repo_list.go	64.55% <0%> (+1.26%)	⬆️
models/repo_indexer.go	47.88% <0%> (+3.38%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b686bd0...b7fadfd. Read the comment docs.

[xor-gate]

Could somebody help me out how to test this case?

[lunny]

@xor-gate drone CI has LDAP service by @lafriks, maybe you can test with it.

[xor-gate]

Yes I understand, I had a look at the CI some time ago. We should add at least an ecdsa key to the LDAP server test image then. At here https://github.com/go-gitea/test-openldap/blob/master/bootstrap/data/10_people_hermes.ldif#L24

[xor-gate]

I have added an ecdsa key to the test-openldap image as PR.

[lafriks]

@xor-gate feel free to submit PR to add key to that test ldap server

[xor-gate]

I updated the PR with the latest changes from master e2292c7 seems master has broken CI build: https://drone.gitea.io/go-gitea/gitea/3652/10

[lafriks]

@xor-gate you need to update tests as more ssh keys are now returned from ldap in test TestLDAPUserSSHKeySync

[xor-gate]

@lafriks finaly the ldap integration test passes now horay 👍 gives me more trust with the added test key