Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect charset and convert non UTF-8 files for display (#4950) #4994

Merged
merged 2 commits into from
Sep 30, 2018
Merged

Detect charset and convert non UTF-8 files for display (#4950) #4994

merged 2 commits into from
Sep 30, 2018

Conversation

lafriks
Copy link
Member

@lafriks lafriks commented Sep 29, 2018

Backport #4879

@lafriks
Detect charset and convert non UTF-8 files for display (go-gitea#4950)
785b17c 
* Detect charset and convert non UTF-8 files for display

* Refactor and move function to correct module

* Revert unrelated changes

* More unrelated changes

* Duplicate content for small text to have better encoding detection

* Check if original content is valid before duplicating it
@lafriks lafriks added this to the 1.5.2 milestone Sep 29, 2018
@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Sep 29, 2018
@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 30, 2018
@lunny lunny merged commit 33c3cbc into go-gitea:release/v1.5 Sep 30, 2018
@lafriks lafriks deleted the backport/fix/chardet_view_file branch October 1, 2018 17:52
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@techknowlogick techknowlogick techknowlogick approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. type/bug
Projects
None yet
Milestone
1.5.2
Development

Successfully merging this pull request may close these issues.
4 participants
@lafriks @lunny @techknowlogick @bkcsoft