Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add noreferrer to rel='noopener` for <a> tags #4328

Merged
merged 6 commits into from Jul 3, 2018
Merged

Add noreferrer to rel='noopener` for <a> tags #4328

merged 6 commits into from Jul 3, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jun 27, 2018 •
edited by ghost
Loading

No description provided.

@techknowlogick techknowlogick added type/enhancement An improvement of existing functionality topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! labels Jun 27, 2018
@codecov-io
Copy link

codecov-io commented Jun 27, 2018 •
edited
Loading

Codecov Report

Merging #4328 into master will not change coverage.
The diff coverage is 0%.

Impacted file tree graph

@@          Coverage Diff           @@
##           master   #4328   +/-   ##
======================================
  Coverage    20.1%   20.1%           
======================================
  Files         153     153           
  Lines       30716   30716           
======================================
  Hits         6174    6174           
  Misses      23599   23599           
  Partials      943     943
Impacted Files Coverage Δ
models/repo.go 18.4% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4b654ad...61a4430. Read the comment docs.

@bkcsoft bkcsoft added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jun 27, 2018
@cezar97
Add missing `rel="noopener noreferrer"'
7ed9b79 
Signed-off-by: cezar97 <[email protected]>
@cezar97
Add missing quotes
a232af2 
Not really related to the PR

Signed-off-by: cezar97 <[email protected]>
@ghost ghost mentioned this pull request Jun 27, 2018
Merged
@techknowlogick
Copy link
Member

@cezar97 Thank you for opening this PR 😄

Only one change requested with this, changes for translation files (that aren't options/locale/locale_en-US.ini) have to be updated through Crowdin. Crowdin supports login through GitHub, and I'd be glad to approve the translations there.

@bkcsoft bkcsoft added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jun 28, 2018
@techknowlogick
Copy link
Member

@cezar97 looks like the translations were added all to Italian
screen shot 2018-06-28 at 2 00 31 pm

I don't have permissions on Crowdin to change those around. This PR is good though, and can remain as is.

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jun 29, 2018
@techknowlogick techknowlogick merged commit 51ba3df into go-gitea:master Jul 3, 2018
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/security Something leaks user information or is otherwise vulnerable. Should be fixed! type/enhancement An improvement of existing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@codecov-io @techknowlogick @sapk @bkcsoft @cezar97