Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Some small template fixes #3820

Merged
merged 1 commit into from
Apr 20, 2018
Merged

Some small template fixes #3820

merged 1 commit into from
Apr 20, 2018

Conversation

rvillablanca
Copy link
Contributor

I made some corrections on a few template files, two unclosed html tags and two required html attributes on <textarea> tags.

@thehowl
Copy link
Contributor

thehowl commented Apr 19, 2018

LGTM

@bkcsoft bkcsoft added the lgtm/need 1 This PR needs approval from one additional maintainer to be merged. label Apr 19, 2018
@codecov-io
Copy link

Codecov Report

Merging #3820 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3820   +/-   ##
=======================================
  Coverage   23.02%   23.02%           
=======================================
  Files         126      126           
  Lines       24894    24894           
=======================================
  Hits         5731     5731           
  Misses      18287    18287           
  Partials      876      876

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bac6d05...b55c84e. Read the comment docs.

@bkcsoft bkcsoft added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Apr 19, 2018
@lunny lunny added the topic/ui Change the appearance of the Gitea UI label Apr 20, 2018
@lunny lunny added this to the 1.5.0 milestone Apr 20, 2018
@lunny lunny merged commit f6013d5 into go-gitea:master Apr 20, 2018
@rvillablanca rvillablanca deleted the small-fixes-templates branch April 20, 2018 03:20
@go-gitea go-gitea locked and limited conversation to collaborators Nov 24, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jonasfranz jonasfranz jonasfranz approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. topic/ui Change the appearance of the Gitea UI
Projects
None yet
Milestone
1.5.0
Development

Successfully merging this pull request may close these issues.
6 participants
@rvillablanca @thehowl @codecov-io @jonasfranz @lunny @bkcsoft