Fix remove team member issue #3566
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #3566 +/- ##
==========================================
+ Coverage 35.78% 35.79% +0.01%
==========================================
Files 285 285
Lines 40850 40863 +13
==========================================
+ Hits 14617 14628 +11
- Misses 24065 24067 +2
Partials 2168 2168
Continue to review full report at Codecov.
|
tboerger
added
the
lgtm/need 2
lunny
requested changes
Feb 23, 2018
| @@ -523,6 +516,16 @@ func RemoveOrgUser(orgID, userID int64) error { | |||
| return sess.Commit() | |||
There was a problem hiding this comment.
Put sess.Commit() out of the function is a good habit I think.
xwjdsh
force-pushed
the
remove_organization_user
branch
from
16bacab
to
cb2fcbc
Compare
|
@lunny You are right, changed. |
lunny
approved these changes
Feb 23, 2018
tboerger
added
lgtm/need 1
appleboy
reviewed
Feb 23, 2018
models/org_team.go
Outdated
| @@ -10,6 +10,7 @@ import ( | |||
| "strings" | |||
|
|
|||
| "code.gitea.io/gitea/modules/log" | |||
| "github.com/go-xorm/xorm" | |||
There was a problem hiding this comment.
Add an empty line between local and external package.
appleboy
suggested changes
Feb 23, 2018
Put sess.Commit() out of the RemoveOrgUser function Add an empty line to separate import packages
xwjdsh
force-pushed
the
remove_organization_user
branch
from
cb2fcbc
to
53a6ccb
Compare
|
@appleboy Updated. |
sapk
approved these changes
Feb 23, 2018
tboerger
added
lgtm/done
appleboy
approved these changes
Feb 23, 2018
|
@xwjdsh can you backport this to |
xwjdsh
added a commit
to xwjdsh/gitea
that referenced
this pull request
Feb 23, 2018
Put sess.Commit() out of the RemoveOrgUser function Add an empty line to separate import packages Signed-off-by: Wendell Sun <[email protected]>
lafriks
pushed a commit
that referenced
this pull request
Feb 23, 2018
Signed-off-by: Wendell Sun <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3410