Fix issue with broken inter-wiki links #3506

[charlesreid1]

This fixes issue #3506, in which inter-wiki links automatically generated in the sidebar contained + signs instead of - signs and were therefore all broken.

[codecov-io]

Codecov Report

Merging #3560 into master will decrease coverage by 0.34%.
The diff coverage is 100%.

@@            Coverage Diff             @@
##           master    #3560      +/-   ##
==========================================
- Coverage   36.14%   35.79%   -0.35%     
==========================================
  Files         285      285              
  Lines       40925    40868      -57     
==========================================
- Hits        14791    14630     -161     
- Misses      23959    24069     +110     
+ Partials     2175     2169       -6

Impacted Files	Coverage Δ
modules/markup/html.go	54.3% <100%> (-35.15%)	⬇️
modules/markup/markup.go	67.27% <0%> (-0.53%)	⬇️
models/repo_indexer.go	48.3% <0%> (ø)	⬆️
routers/admin/admin.go	0% <0%> (ø)	⬆️
models/repo.go	42.8% <0%> (+0.05%)	⬆️
routers/repo/attachment.go	13.33% <0%> (+0.28%)	⬆️
models/gpg_key.go	56.41% <0%> (+0.53%)	⬆️
modules/templates/helper.go	49.65% <0%> (+1.74%)	⬆️
modules/markup/markdown/markdown.go	68.69% <0%> (+2.34%)	⬆️
... and 1 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 171914e...1319642. Read the comment docs.

[lunny]

Maybe when iswiki is true, we should use - instead of +?

[charlesreid1]

Just to pull this out of the (buried) comment in the last commit:

There are two more locations where +s are added to links, making me think + was chosen for a reason. @lunny adding a check for iswiki would be good - when are the + signs used in links? when links are to files within the repo?

[lafriks]

@charlesreid1 yes as files added to wiki git can contain spaces

[lafriks]

@charlesreid1 I hope you do not mind I overwrite your commit as only single place was needed to be changed afaik. Also added tests for links with spaces.

[charlesreid1]

Thanks for fixing this up @lafriks!

[lafriks]

@charlesreid1 thanks for pinpointing the problem ;)