Change local copy origin url after repository rename #3399
Conversation
tboerger
added
the
lgtm/need 1
lafriks
changed the title
|
Thanks a lot @xwjdsh ^-^ |
|
CI fails for Postgres: https://drone.gitea.io/go-gitea/gitea/3281/10 |
tboerger
added
lgtm/done
|
CI failed is related to #3386 not this PR |
| return fmt.Errorf("rename repository directory: %v", err) | ||
| } | ||
|
|
||
| localPath := repo.LocalCopyPath() | ||
| if com.IsExist(localPath) { | ||
| _, err := git.NewCommand("remote", "set-url", "origin", newRepoPath).RunInDir(localPath) |
There was a problem hiding this comment.
You usually need to acquire a lock before running a git command in the local copy repo, although I suppose in this case it may be alright not to
There was a problem hiding this comment.
Actually, if we really wanted to be safe, we would hold the local-copy lock while renaming the bare repo and while running git remote set-url origin ....
Between renaming the bare repo and running git remote set-url origin ..., any other threads that try to run git commands involving origin in the local copy will fail.
There was a problem hiding this comment.
thanks, you are right, I'll try to do it.
Codecov Report
@@ Coverage Diff @@
## master #3399 +/- ##
=========================================
Coverage ? 35.58%
=========================================
Files ? 281
Lines ? 40586
Branches ? 0
=========================================
Hits ? 14442
Misses ? 24004
Partials ? 2140
Continue to review full report at Codecov.
|
Fix #3378 . Updated local copy repository's git remote URL after repository renamed.