Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix tag route and empty repo #33253

Merged
merged 1 commit into from
Jan 14, 2025
Merged

Fix tag route and empty repo #33253

merged 1 commit into from
Jan 14, 2025

Conversation

wxiaoguang
Copy link
Contributor

No description provided.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 14, 2025
@GiteaBot GiteaBot added this to the 1.23.2 milestone Jan 14, 2025
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Jan 14, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jan 14, 2025
@wxiaoguang wxiaoguang changed the title Fix tag route Fix tag route and improve empty repo handling Jan 14, 2025
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 14, 2025
@wxiaoguang wxiaoguang changed the title Fix tag route and improve empty repo handling Fix tag route Jan 14, 2025
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 14, 2025
@wxiaoguang wxiaoguang marked this pull request as draft January 14, 2025 04:08
@wxiaoguang
Copy link
Contributor Author

Wait for a while, need to figure out another problem

@pull-request-size pull-request-size bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jan 14, 2025
@wxiaoguang wxiaoguang changed the title Fix tag route Fix tag route and empty repo Jan 14, 2025
@wxiaoguang wxiaoguang marked this pull request as ready for review January 14, 2025 04:56
@wxiaoguang
Copy link
Contributor Author

Fine tune the empty repo handling and added some new tests

@wxiaoguang wxiaoguang merged commit 80cc87b into go-gitea:release/v1.23 Jan 14, 2025
26 checks passed
@wxiaoguang wxiaoguang deleted the backport-tag-fix branch January 14, 2025 06:01
@wxiaoguang wxiaoguang mentioned this pull request Jan 14, 2025
Merged
lunny added a commit that referenced this pull request Jan 14, 2025
@lunny @wxiaoguang
Refactor ref type (#33242)
6410c34 
Major changes:

1. do not sync ".keep" file during tests
2. fix incorrect route handler and empty repo handling (backported as #33253 with tests)
3. do not use `RepoRef`: most of the calls are abuses.
4. Use `git.RefType` instead of a new type definition `RepoRefType` on `context`.

---------

Co-authored-by: wxiaoguang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hiifong hiifong hiifong approved these changes

@lunny lunny lunny approved these changes

Assignees
No one assigned
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
1.23.2
Development

Successfully merging this pull request may close these issues.
4 participants
@wxiaoguang @lunny @hiifong @GiteaBot