-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor older tests to use testify #33140
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Jan 7, 2025
pull-request-size
bot
added
the
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
label
Jan 7, 2025
TheFox0x7
force-pushed
the
test-refactor
branch
from
January 8, 2025 18:51
b20938c
to
437d8bd
Compare
pull-request-size
bot
added
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
and removed
size/L
Denotes a PR that changes 100-499 lines, ignoring generated files.
labels
Jan 8, 2025
TheFox0x7
force-pushed
the
test-refactor
branch
from
January 8, 2025 19:04
f00759e
to
cdcc8a8
Compare
TheFox0x7
force-pushed
the
test-refactor
branch
from
January 8, 2025 19:05
cdcc8a8
to
0c074fe
Compare
lunny
approved these changes
Jan 9, 2025
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Jan 9, 2025
wxiaoguang
approved these changes
Jan 9, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, much clearer than before.
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Jan 9, 2025
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Jan 10, 2025
* giteaofficial/main: Fix raw file API ref handling (go-gitea#33172) [skip ci] Updated translations via Crowdin Fix ACME panic (go-gitea#33178) Automerge supports deleting branch automatically after merging (go-gitea#32343) Fix branch dropdown not display ref name (go-gitea#33159) Add .run to gitignore (go-gitea#33175) Fix assignee list overlapping in Issue sidebar (go-gitea#33176) Fix pam auth test regression (go-gitea#33169) Move repo size to sidebar (go-gitea#33155) Fix fuzz test (go-gitea#33156) Refactor older tests to use testify (go-gitea#33140) [skip ci] Updated translations via Crowdin Fix typo in gitea downloader test and add missing codebase in `ToGitServiceType` (go-gitea#33146) Fix form width (go-gitea#33151) Convert github.com/xanzy/go-gitlab into gitlab.com/gitlab-org/api/client-go (go-gitea#33126) Refactor HTMLFormat, update chroma render, fix js error (go-gitea#33136) Add missed transaction on setmerged (go-gitea#33079)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
modifies/go
Pull requests that update Go code
size/XL
Denotes a PR that changes 500-999 lines, ignoring generated files.
type/testing
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor checks to use assert/require
Use require.Eventually for waiting in elastic and meilisearch tests
Use require to exit early instead of assert