Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor older tests to use testify #33140

Merged
merged 3 commits into from
Jan 9, 2025
Merged

Conversation

TheFox0x7
Copy link
Contributor

@TheFox0x7 TheFox0x7 commented Jan 7, 2025

Refactor checks to use assert/require
Use require.Eventually for waiting in elastic and meilisearch tests
Use require to exit early instead of assert

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jan 7, 2025
@pull-request-size pull-request-size bot added the size/L Denotes a PR that changes 100-499 lines, ignoring generated files. label Jan 7, 2025
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Jan 7, 2025
@pull-request-size pull-request-size bot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jan 8, 2025
@TheFox0x7 TheFox0x7 marked this pull request as ready for review January 8, 2025 19:04
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jan 9, 2025
Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome, much clearer than before.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jan 9, 2025
@wxiaoguang wxiaoguang merged commit 2a02734 into go-gitea:main Jan 9, 2025
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Jan 9, 2025
zjjhot added a commit to zjjhot/gitea that referenced this pull request Jan 10, 2025
* giteaofficial/main:
  Fix raw file API ref handling (go-gitea#33172)
  [skip ci] Updated translations via Crowdin
  Fix ACME panic (go-gitea#33178)
  Automerge supports deleting branch automatically after merging (go-gitea#32343)
  Fix branch dropdown not display ref name (go-gitea#33159)
  Add .run to gitignore (go-gitea#33175)
  Fix assignee list overlapping in Issue sidebar (go-gitea#33176)
  Fix pam auth test regression (go-gitea#33169)
  Move repo size to sidebar (go-gitea#33155)
  Fix fuzz test (go-gitea#33156)
  Refactor older tests to use testify (go-gitea#33140)
  [skip ci] Updated translations via Crowdin
  Fix typo in gitea downloader test and add missing codebase in `ToGitServiceType` (go-gitea#33146)
  Fix form width (go-gitea#33151)
  Convert github.com/xanzy/go-gitlab into gitlab.com/gitlab-org/api/client-go (go-gitea#33126)
  Refactor HTMLFormat, update chroma render, fix js error (go-gitea#33136)
  Add missed transaction on setmerged (go-gitea#33079)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. type/testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants