Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove aws go sdk package dependency #33029

Merged
merged 9 commits into from
Dec 30, 2024
Merged

Remove aws go sdk package dependency #33029

merged 9 commits into from
Dec 30, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented Dec 29, 2024 •
edited by wxiaoguang
Loading

This PR removed the dependency of github.com/aws/aws-sdk-go/aws

Patially fix for #33023

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 29, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 29, 2024
@lunny lunny added backport/v1.23 This PR should be backported to Gitea 1.23 and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Dec 29, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Dec 29, 2024
@lunny lunny added topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. and removed modifies/go Pull requests that update Go code labels Dec 29, 2024
@lunny lunny force-pushed the lunny/remove_aws_dep branch from a0ff572 to d25f056 Compare December 29, 2024 06:31
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Dec 29, 2024
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Dec 29, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Dec 29, 2024
@wxiaoguang

This comment was marked as resolved.

Sign in to view
@wxiaoguang
Copy link
Contributor

And there is

image

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Dec 29, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Dec 30, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 30, 2024
@lunny lunny enabled auto-merge (squash) December 30, 2024 02:20
@GiteaBot GiteaBot removed the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label Dec 30, 2024
@wxiaoguang wxiaoguang mentioned this pull request Dec 30, 2024
Closed
@go-gitea go-gitea deleted a comment from GiteaBot Dec 30, 2024
@lunny lunny merged commit 8eecca3 into go-gitea:main Dec 30, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Dec 30, 2024
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request Dec 30, 2024
@lunny @GiteaBot
Remove aws go sdk package dependency (go-gitea#33029)
eb7cb6a 
This PR removed the dependency of `github.com/aws/aws-sdk-go/aws`

Patially fix for go-gitea#33023
@GiteaBot GiteaBot mentioned this pull request Dec 30, 2024
Merged
@lunny lunny deleted the lunny/remove_aws_dep branch December 30, 2024 06:30
@GiteaBot GiteaBot added the backport/done All backports for this PR have been created label Dec 30, 2024
wxiaoguang pushed a commit that referenced this pull request Dec 30, 2024
@GiteaBot @lunny
Remove aws go sdk package dependency (#33029) (#33047)
d2d7633 
Backport #33029 by lunny

Co-authored-by: Lunny Xiao <[email protected]>
zjjhot added a commit to zjjhot/gitea that referenced this pull request Dec 31, 2024
@zjjhot
Merge remote-tracking branch 'giteaofficial/main'
8aaec8e 
* giteaofficial/main:
  Fix issue comment number (go-gitea#30556)
  Fix duplicate co-author in squashed merge commit messages (go-gitea#33020)
  Merge updatecommentattachment functions (go-gitea#33044)
  Move SetMerged to service layer (go-gitea#33045)
  Remove aws go sdk package dependency (go-gitea#33029)
  Fix settings not being loaded at CLI (go-gitea#26402)
  Refactor fixture loading for testing (go-gitea#33024)
  Use gitrepo.GetTreePathLatestCommit to get file lastest commit instead from latest commit cache (go-gitea#32987)
  Fix bug automerge cannot be chosed when there is only 1 merge style (go-gitea#33040)
  use `-s -w` ldflags for release artifacts (go-gitea#33041)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Zettat123 Zettat123 Zettat123 approved these changes

@wxiaoguang wxiaoguang wxiaoguang approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.23 This PR should be backported to Gitea 1.23 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/dependencies modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-changelog This PR is irrelevant for the (next) changelog, for example bug fixes for unreleased features. topic/build PR changes how Gitea is built, i.e. regarding Docker or the Makefile
Projects
None yet
Milestone
1.24.0
Development

Successfully merging this pull request may close these issues.
4 participants
@lunny @wxiaoguang @Zettat123 @GiteaBot