Do not render truncated links in markdown #32980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
pull-request-size
bot
added
the
size/M
wxiaoguang
added
type/bug
backport/v1.23
wxiaoguang
force-pushed
the
fix-link-truncate
branch
from
ffca29f to
4bf8172
Compare
delvh
reviewed
Dec 25, 2024
| @@ -14,6 +14,10 @@ const ( | |||
| asciiEllipsis = "..." | |||
| ) | |||
|
|
|||
| func IsLikelySplitLeftPart(s string) bool { | |||
There was a problem hiding this comment.
Nope, "Truncated" doesn't have such "..."
It matches the original function below "SplitStringAtByteN"
There was a problem hiding this comment.
I think we can refactor these "truncate" related function in the future together, while keep this PR simple to backport
There was a problem hiding this comment.
-> Refactor "string truncate" #32984
delvh
approved these changes
Dec 25, 2024
GiteaBot
added
lgtm/need 1
lunny
approved these changes
Dec 25, 2024
GiteaBot
added
lgtm/done
GiteaBot
pushed a commit
to GiteaBot/gitea
that referenced
this pull request
Dec 25, 2024
wxiaoguang
added a commit
that referenced
this pull request
Dec 25, 2024
Backport #32980 by wxiaoguang Co-authored-by: wxiaoguang <[email protected]>
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Dec 26, 2024
* giteaofficial/main: Do not render truncated links in markdown (go-gitea#32980) Use `CloseIssue` and `ReopenIssue` instead of `ChangeStatus` (go-gitea#32467)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.