Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect "Target branch does not exist" in PR title #32222

Merged
merged 1 commit into from
Oct 10, 2024

Conversation

Zettat123
Copy link
Contributor

@Zettat123 Zettat123 commented Oct 9, 2024

This issue may be caused by #32000

"Target branch does not exist" is always displayed when the head branch is form a forked repo

image

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Oct 9, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 9, 2024
@github-actions github-actions bot added the modifies/go Pull requests that update Go code label Oct 9, 2024
@lunny
Copy link
Member

lunny commented Oct 9, 2024

How about adding a deletion for the deleted branch like what github did.
user3/pr-branch

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Oct 9, 2024
@Zettat123
Copy link
Contributor Author

How about adding a deletion for the deleted branch like what github did. user3/pr-branch

Yes. I think we can create another PR to support this.

@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Oct 10, 2024
@lunny lunny merged commit 4eacc61 into go-gitea:main Oct 10, 2024
26 checks passed
@GiteaBot GiteaBot added this to the 1.24.0 milestone Oct 10, 2024
zjjhot added a commit to zjjhot/gitea that referenced this pull request Oct 10, 2024
* giteaofficial/main:
  Refactor CSRF token (go-gitea#32216)
  [skip ci] Updated translations via Crowdin
  Fix incorrect "Target branch does not exist" in PR title (go-gitea#32222)
  update git book link to v2 (go-gitea#32221)
  [skip ci] Updated translations via Crowdin
  Add null check for responseData.invalidTopics (go-gitea#32212)
  Fix bug when a token is given public only (go-gitea#32204)
@wxiaoguang wxiaoguang modified the milestones: 1.24.0, 1.23.0 Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants