-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix javascript error when an anonymous user visiting migration page #32144
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How to reproduce?
migrate a big repository and visit the repository with anonymous. |
JS: |
|
-> Fix view repo migration task logic #32152
Update: 32152 is just an example about the XORM usage problem. Actually, the "repo migrating" page has a lot of problems. This PR is far from ideal either (actually I wouldn't say this PR is right).
To make things right, it needs to use something like |
Co-authored-by: wxiaoguang <[email protected]>
I was unable to create a backport for 1.22. @lunny, please send one manually. 🍵
|
…o-gitea#32144) This PR fixes javascript errors when an anonymous user visits the migration page. It also makes task view checking more restrictive. The router moved from `/user/task/{id}/status` to `/username/reponame/-/migrate/status` because it's a migrate status. --------- Co-authored-by: wxiaoguang <[email protected]>
* giteaofficial/main: Fix javascript error when an anonymous user visiting migration page (go-gitea#32144) Make oauth2 code clear. Move oauth2 provider code to their own packages/files (go-gitea#32148) Support repo license (go-gitea#24872) Fix the logic of finding the latest pull review commit ID (go-gitea#32139) Ensure `GetCSRF` doesn't return an empty token (go-gitea#32130) Bump minio-go to latest version (go-gitea#32156)
…32144) (#32179) backport #32144 This PR fixes javascript errors when an anonymous user visits the migration page. It also makes task view checking more restrictive. The router moved from `/user/task/{id}/status` to `/username/reponame/-/migrate/status` because it's a migrate status. Co-authored-by: wxiaoguang <[email protected]>
This PR fixes javascript errors when an anonymous user visits the migration page.
It also makes task view checking more restrictive.
The router moved from
/user/task/{id}/status
to/username/reponame/-/migrate/status
because it's a migrate status.