Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix /repos/{owner}/{repo}/pulls/{index}/files endpoint not populating previous_filename (#32017) #32028

Merged
merged 1 commit into from
Sep 11, 2024

Conversation

GiteaBot
Copy link
Collaborator

Backport #32017 by @charles-plutohealth


status == "rename" should have read status == "renamed". The typo means that file.PreviousFilename would never be populated, which e.g. breaks usage of the Github Action at https://github.com/dorny/paths-filter.

…ng `previous_filename` (go-gitea#32017)

---
`status == "rename"` should have read `status == "renamed"`. The typo
means that file.PreviousFilename would never be populated, which e.g.
breaks usage of the Github Action at
https://github.com/dorny/paths-filter.
@GiteaBot GiteaBot added modifies/go Pull requests that update Go code type/bug labels Sep 11, 2024
@GiteaBot GiteaBot requested a review from delvh September 11, 2024 17:29
@GiteaBot GiteaBot added this to the 1.22.3 milestone Sep 11, 2024
@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Sep 11, 2024
@GiteaBot GiteaBot requested review from lunny and yp05327 September 11, 2024 17:29
@pull-request-size pull-request-size bot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Sep 11, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Sep 11, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Sep 11, 2024
@yp05327 yp05327 merged commit b3af359 into go-gitea:release/v1.22 Sep 11, 2024
26 checks passed
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Dec 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code size/S Denotes a PR that changes 10-29 lines, ignoring generated files. type/bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants