-
-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add automatic light/dark option for the colorblind theme #31997
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GiteaBot
added
the
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
label
Sep 6, 2024
pull-request-size
bot
added
the
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
label
Sep 6, 2024
silverwind
approved these changes
Sep 6, 2024
GiteaBot
added
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
and removed
lgtm/need 2
This PR needs two approvals by maintainers to be considered for merging.
labels
Sep 6, 2024
I don't like these theme names but it's not the fault of this PR as it's consistent. |
delvh
approved these changes
Sep 6, 2024
GiteaBot
added
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
and removed
lgtm/need 1
This PR needs approval from one additional maintainer to be merged.
labels
Sep 6, 2024
@silverwind offtopic, but: That is the scientific name after all. |
techknowlogick
added
type/feature
Completely new functionality. Can only be merged if feature freeze is not active.
type/changelog
Adds the changelog for a new Gitea version
labels
Sep 7, 2024
techknowlogick
added
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Sep 7, 2024
GiteaBot
removed
the
reviewed/wait-merge
This pull request is part of the merge queue. It will be merged soon.
label
Sep 7, 2024
zjjhot
added a commit
to zjjhot/gitea
that referenced
this pull request
Sep 9, 2024
* giteaofficial/main: [skip ci] Updated licenses and gitignores [skip ci] Updated translations via Crowdin Remove SHA1 for support for ssh rsa signing (go-gitea#31857) Upgrade cache to v0.2.1 (go-gitea#32003) Add automatic light/dark option for the colorblind theme (go-gitea#31997) [skip ci] Updated translations via Crowdin Use global lock instead of NewExclusivePool to allow distributed lock between multiple Gitea instances (go-gitea#31813) Use forum.gitea.com instead of old URL (go-gitea#31989) Distinguish official vs non-official reviews, add tool tips, and upgr… (go-gitea#31924)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
lgtm/done
This PR has enough approvals to get merged. There are no important open reservations anymore.
size/XS
Denotes a PR that changes 0-9 lines, ignoring generated files.
type/changelog
Adds the changelog for a new Gitea version
type/feature
Completely new functionality. Can only be merged if feature freeze is not active.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The normal themes already have a variant which automatically chooses light/dark mode based on the browser.
This PR adds the same variant, but for the colorblind themes.