Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix possible ui 500 if workflow's job is nil #31092

Merged
merged 3 commits into from
May 27, 2024
Merged

Fix possible ui 500 if workflow's job is nil #31092

merged 3 commits into from
May 27, 2024

Conversation

lunny
Copy link
Member

@lunny lunny commented May 27, 2024

Fix #31087

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label May 27, 2024
@pull-request-size pull-request-size bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 27, 2024
@lunny lunny requested a review from Zettat123 May 27, 2024 01:24
@github-actions github-actions bot added modifies/translation modifies/go Pull requests that update Go code labels May 27, 2024
@lunny lunny requested a review from yp05327 May 27, 2024 01:24
@lunny lunny added the backport/v1.22 This PR should be backported to Gitea 1.22 label May 27, 2024
@lunny lunny added this to the 1.23.0 milestone May 27, 2024
@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels May 27, 2024
@GiteaBot GiteaBot added lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels May 27, 2024
@lunny lunny added the reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. label May 27, 2024
@lunny lunny enabled auto-merge (squash) May 27, 2024 04:41
@yp05327
Copy link
Contributor

yp05327 commented May 27, 2024

And I also agree refactor it later, move no_job_without_needs and no_job to ReadWorkflow, the error is just invalid_workflow.

emmm, don't forget doing it. Then it is ok.

@lunny lunny merged commit e695ba4 into go-gitea:main May 27, 2024
26 checks passed
GiteaBot pushed a commit to GiteaBot/gitea that referenced this pull request May 27, 2024
@lunny @GiteaBot
Fix possible ui 500 if workflow's job is nil (go-gitea#31092)
198e8a5 
Fix go-gitea#31087
@GiteaBot GiteaBot mentioned this pull request May 27, 2024
Merged
@GiteaBot GiteaBot added backport/done All backports for this PR have been created and removed reviewed/wait-merge This pull request is part of the merge queue. It will be merged soon. labels May 27, 2024
lunny added a commit that referenced this pull request May 27, 2024
@GiteaBot @lunny
Fix possible ui 500 if workflow's job is nil (#31092) (#31098)
e0b7938 
Backport #31092 by @lunny

Fix #31087

Co-authored-by: Lunny Xiao <[email protected]>
@lunny lunny deleted the lunny/fix_workflow_job_broken branch May 30, 2024 14:49
@go-gitea go-gitea locked as resolved and limited conversation to collaborators Aug 25, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@yp05327 yp05327 yp05327 left review comments

@Zettat123 Zettat123 Zettat123 approved these changes

@wolfogre wolfogre wolfogre approved these changes

Assignees
No one assigned
Labels
backport/done All backports for this PR have been created backport/v1.22 This PR should be backported to Gitea 1.22 lgtm/done This PR has enough approvals to get merged. There are no important open reservations anymore. modifies/go Pull requests that update Go code modifies/translation size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.23.0
Development

Successfully merging this pull request may close these issues.

[Bug: 1.22.0-rc1] Actions interface is replaced by errors on validation fail
5 participants
@lunny @yp05327 @wolfogre @Zettat123 @GiteaBot